Skip to content

Fix ci#105

Merged
jaideraf merged 4 commits intomasterfrom
fix-ci
Feb 25, 2025
Merged

Fix ci#105
jaideraf merged 4 commits intomasterfrom
fix-ci

Conversation

@paladox
Copy link
Copy Markdown
Contributor

@paladox paladox commented Feb 20, 2025

  • This doesn't fix MW 1.43 ci as that was broken before but it fixes for MW 1.42 and lower. Marks MW 1.43 ci as experimental for now.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.20%. Comparing base (87e4f04) to head (932ebec).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage     76.20%   76.20%           
  Complexity      716      716           
=========================================
  Files            36       36           
  Lines          2320     2320           
=========================================
  Hits           1768     1768           
  Misses          552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paladox
Copy link
Copy Markdown
Contributor Author

paladox commented Feb 20, 2025

SemanticResultFormats ext is fixed in SemanticMediaWiki/SemanticResultFormats#906

@JeroenDeDauw
Copy link
Copy Markdown
Member

@paladox could you have a look at https://github.com/ProfessionalWiki/Maps/tree/master/src/SemanticMW to see if anything is broken there after the class alias removal?

@JeroenDeDauw
Copy link
Copy Markdown
Member

CI is still failing with

There was 1 error:

  1. SD\Tests\Integration\JSONScript\JsonTestCaseScriptRunnerTest::testCaseFile with data set "result-formats.json" ('/var/www/html/extensions/Sema...s.json')
    Error: Class "SMWResultPrinter" not found

/var/www/html/extensions/SemanticResultFormats/formats/jqplot/SRF_jqPlotSeries.php:11
/var/www/html/extensions/SemanticMediaWiki/includes/query/SMW_QueryProcessor.php:402
/var/www/html/extensions/SemanticDrilldown/includes/Specials/BrowseData/SemanticResultPrinter.php:45

@paladox
Copy link
Copy Markdown
Contributor Author

paladox commented Feb 20, 2025

CI is still failing with

There was 1 error:

  1. SD\Tests\Integration\JSONScript\JsonTestCaseScriptRunnerTest::testCaseFile with data set "result-formats.json" ('/var/www/html/extensions/Sema...s.json')
    Error: Class "SMWResultPrinter" not found

/var/www/html/extensions/SemanticResultFormats/formats/jqplot/SRF_jqPlotSeries.php:11 /var/www/html/extensions/SemanticMediaWiki/includes/query/SMW_QueryProcessor.php:402 /var/www/html/extensions/SemanticDrilldown/includes/Specials/BrowseData/SemanticResultPrinter.php:45

See #105 (comment) @JeroenDeDauw

@paladox
Copy link
Copy Markdown
Contributor Author

paladox commented Feb 20, 2025

@paladox could you have a look at https://github.com/ProfessionalWiki/Maps/tree/master/src/SemanticMW to see if anything is broken there after the class alias removal?

Sure. Update: Done. Only some comments that need updating which are minor.

@gesinn-it-gea
Copy link
Copy Markdown
Member

@paladox should this be merged after SRF, Maps and SMW?

@paladox
Copy link
Copy Markdown
Contributor Author

paladox commented Feb 21, 2025

@paladox should this be merged after SRF, Maps and SMW?

I don't think Maps affects this one. I'm not seeing in the error in CI. But sure.

@paladox
Copy link
Copy Markdown
Contributor Author

paladox commented Feb 23, 2025

Bump :)

(CI should now pass except for MW 1.43).

@jaideraf jaideraf merged commit 990180a into master Feb 25, 2025
6 of 7 checks passed
@jaideraf jaideraf deleted the fix-ci branch February 25, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants