handle SPARQLStore backends#861
Open
simontaurus wants to merge 2 commits intoSemanticMediaWiki:masterfrom
Open
handle SPARQLStore backends#861simontaurus wants to merge 2 commits intoSemanticMediaWiki:masterfrom
simontaurus wants to merge 2 commits intoSemanticMediaWiki:masterfrom
Conversation
Member
There was a problem hiding this comment.
Since $this->datatables->store is used multiple time, maybe it should be set as a variable instead.
I'm not familiar with SPARQLStore so I can't review the PR, perhaps @thomas-topway-it can take a look at it.
Member
|
If I understand correctly, we can close this, since the issue will be fixed by SMW 5.0 anyway (via SemanticMediaWiki/SemanticMediaWiki@8bfd7a9).
I would consider doing so adding accidental complexity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #827
See also SemanticMediaWiki/SemanticMediaWiki#5748
With the next SMW release including SemanticMediaWiki/SemanticMediaWiki@8bfd7a9 the Closure can be removed