fix: trim '-' from property labels before calling DIProperty::newFromUserLabel

[simontaurus]

fixes #920

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.52%. Comparing base (a95d3b8) to head (ef51ea5).

Files with missing lines	Patch %	Lines
formats/datatables/SearchPanes.php	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #921   +/-   ##
=========================================
  Coverage     45.52%   45.52%           
  Complexity     2319     2319           
=========================================
  Files            80       80           
  Lines          9050     9050           
=========================================
  Hits           4120     4120           
  Misses         4930     4930           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thomas-topway-it]

is it sufficient to handle inverse properties ?

[simontaurus]

is it sufficient to handle inverse properties ?

Unfortunately not.
We get the right property but I guess these SQL queries also need adaption:

SemanticResultFormats/formats/datatables/SearchPanes.php

Line 246 in 02c08ce

$res = $this->connection->select(

With search_panes disable, inverse properties are working fine. With search_panes enabled and this fix applied, the corresponding columns stay empty while the search pane shows the value of the forward relation value instead of the reverse => The correct property is selected but the query is not reversed.

Is there a reason for all this custom SQL? Any chance to replace it with SMW Queries?

[thomas-topway-it]

@simontaurus actually not, I guess most of them can be replaced using the new or legacy MW query builder

[alistair3149]

@simontaurus actually not, I guess most of them can be replaced using the new or legacy MW query builder

We probably should since this might also resolve #910, but I don't have the expertise needed to update the SQL queries in the DataTables implementation