listwidget: fix template parameter#941
Merged
thomas-topway-it merged 3 commits intoSemanticMediaWiki:masterfrom Nov 27, 2025
Merged
listwidget: fix template parameter#941thomas-topway-it merged 3 commits intoSemanticMediaWiki:masterfrom
thomas-topway-it merged 3 commits intoSemanticMediaWiki:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #941 +/- ##
============================================
+ Coverage 45.39% 46.44% +1.05%
Complexity 2326 2326
============================================
Files 80 80
Lines 9078 9083 +5
============================================
+ Hits 4121 4219 +98
+ Misses 4957 4864 -93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
formats/widget/SRF_ListWidget.php
Outdated
| ] ); | ||
|
|
||
| // this does not seem to work | ||
| if ( $this->hasTemplates ) { |
Member
There was a problem hiding this comment.
Then why are you adding it?
Contributor
Author
There was a problem hiding this comment.
I would like to disable links when template parameter is defined, do you have any hint how to achieve this ?
Contributor
Author
There was a problem hiding this comment.
fixed, I've commented the block
This was referenced Jul 17, 2025
Merged
Member
|
Is this ready to be merged? |
Contributor
Author
|
I think so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #618