Skip to content

use structured queries#961

Merged
alistair3149 merged 4 commits intoSemanticMediaWiki:feat-datatables-searchpanes-structured-queriesfrom
Knowledge-Wiki:datatables-searchpanes-structured-queries
Sep 24, 2025
Merged

use structured queries#961
alistair3149 merged 4 commits intoSemanticMediaWiki:feat-datatables-searchpanes-structured-queriesfrom
Knowledge-Wiki:datatables-searchpanes-structured-queries

Conversation

@thomas-topway-it
Copy link
Copy Markdown
Contributor

@thomas-topway-it thomas-topway-it commented Aug 23, 2025

-- considers this #942

-- fixes #910

-- uses structured queries instead of raw joins in the from clause

@thomas-topway-it thomas-topway-it mentioned this pull request Aug 23, 2025
Closed
@thomas-topway-it thomas-topway-it mentioned this pull request Aug 23, 2025
Closed
LukasGold added a commit to OpenSemanticLab/SemanticResultFormats that referenced this pull request Aug 25, 2025
@LukasGold
Merge branch 'searchpanes-pr' into update-pr961
b05926a 
Merging SemanticMediaWiki#961
@alistair3149 alistair3149 changed the base branch from master to feat-datatables-searchpanes-structured-queries September 24, 2025 18:58
@alistair3149 alistair3149 merged commit e7773b3 into SemanticMediaWiki:feat-datatables-searchpanes-structured-queries Sep 24, 2025
0 of 5 checks passed
@alistair3149
Copy link
Copy Markdown
Member

alistair3149 commented Sep 24, 2025

Merging it to a separate branch for testing

@thomas-topway-it
Copy link
Copy Markdown
Contributor Author

thomas-topway-it commented Sep 24, 2025

@alistair3149 I've found out there is an issue with the method parseQuerySegment, sometimes joinConditions and/or fromTables are empty in the root segment. I've found a better solution emulating QuerySegmentListProcessor, and keeping the structured queries, I was about to complete it

@alistair3149 alistair3149 mentioned this pull request Sep 24, 2025
Closed
@alistair3149
Copy link
Copy Markdown
Member

alistair3149 commented Sep 24, 2025

@alistair3149 I've found out there is an issue with the method parseQuerySegment, sometimes joinConditions and/or fromTables are empty in the root segment. I've found a better solution emulating QuerySegmentListProcessor, and keeping the structured queries, I was about to complete it

Would you be able to merge them into feat-datatables-searchpanes-structured-queries please? If the change is a complete rewrite, then please let me know and I will remove the branch.

In that way we can keep the branch available on Packagist for easier testing and cleanups.

@thomas-topway-it
Copy link
Copy Markdown
Contributor Author

thomas-topway-it commented Sep 29, 2025

@alistair3149 done -- I wanted to test also here https://fina.knowledge.wiki/Test_Datatables but there is some other issue.
After testing, I have a better idea how to use the QuerySegmentListProcessor, but the functionality will be the same

thomas-topway-it added a commit that referenced this pull request Dec 24, 2025
@thomas-topway-it @alistair3149 @translatewiki
Datatables searchpanes structured queries (#986)
eda0973 
* use structured queries

* fix phpcs

* fix phpcs

* remove commented line

* Use structured queries for datatables (#961)

* Fix various PHPCS errors

* use QuerySegmentListProcessor

* Create QuerySegmentListProcessor.php

* remove comment

* remove author

* Datatables searchpanes structured queries (#969)

* use structured queries

* fix phpcs

* fix phpcs

* remove commented line

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* use QuerySegmentListProcessor

* Create QuerySegmentListProcessor.php

* remove comment

* remove author

---------

Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>

* fix phpcs

* fix phpcs

* Datatables searchpanes structured queries (#970)

* use structured queries

* fix phpcs

* fix phpcs

* remove commented line

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* use QuerySegmentListProcessor

* Create QuerySegmentListProcessor.php

* remove comment

* remove author

* fix phpcs

* fix phpcs

---------

Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>

* fix phpcs

* fix phpcs

* fix phpcs

* fix phpcs

* fix phpcs

* add use SMWDataItem

* add remove quotes from $smwtable

* add use ISQLPlatform

* update subobjects query

* sort use statements

---------

Co-authored-by: alistair3149 <alistair31494322@gmail.com>
Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[datatables] Table name component contains unexpected quote or dot character with SearchPane

2 participants

@thomas-topway-it @alistair3149