Fix tableName() usage in SearchPanes

[huaj1ng]

• Solves [datatables] Table name component contains unexpected quote or dot character with SearchPane #910 with reference to Fix SearchPanes #942
• In select queries, we use $qobj->fromTables() and $qobj->joinConditions added in Convert SQL select() to use only table names and join conditions SemanticMediaWiki#5715

[thomas-topway-it]

@huaj1ng thanks this is the proper solution after this change SemanticMediaWiki/SemanticMediaWiki#5715

could you please rebase over this #986 adding a condition to use your patch with the proper SMW version ? then I will try to simplify the cloned QuerySegmentListProcessor.php class for backwards compatibility

[thomas-topway-it]

see comment

[huaj1ng]

Please excuse the delayed reply. After checking #986 carefully, I noticed that it already interprets all key ideas of this PR in a neater way, which looks cleaner than the style of SemanticMediaWiki/SemanticMediaWiki#5715, the one I was trying to mimic.

From what I can see, the purpose of this PR is then drained - what I can improve is now merely a few null checks - it is up to your decision to use them or not.

I am not sure about "adding a condition to use your patch with the proper SMW version": as for the tableName() usage we are only using a similar way of constructing queries like SemanticMediaWiki here, but not relying on certain SMW version - please share your insight if my understanding is incomplete.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.09%. Comparing base (d02b217) to head (7a82113).

Files with missing lines	Patch %	Lines
formats/datatables/SearchPanes.php	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #975   +/-   ##
=========================================
  Coverage     45.09%   45.09%           
- Complexity     2422     2425    +3     
=========================================
  Files            81       81           
  Lines          9197     9196    -1     
=========================================
  Hits           4147     4147           
+ Misses         5050     5049    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.