Skip to content

Fixing tagcloud issues due d3 v6 incompatabilities.#981

Merged
jaideraf merged 3 commits intoSemanticMediaWiki:masterfrom
YOUR1:tagcloud-fix
Jan 31, 2026
Merged

Fixing tagcloud issues due d3 v6 incompatabilities.#981
jaideraf merged 3 commits intoSemanticMediaWiki:masterfrom
YOUR1:tagcloud-fix

Conversation

@YOUR1
Copy link
Contributor

@YOUR1 YOUR1 commented Nov 27, 2025

Makes the tag cloud work again.

TypeError: Cannot read properties of undefined (reading 'category20b')
    at jQuery.fn.init.wordcloud (ext.srf.formats.tagcloud.js:149:24)
    at jQuery.fn.init.<anonymous> (ext.srf.formats.tagcloud.js:236:23)
    at HTMLDivElement.loop (ext.smw.js:292:15)
    at loop (jquery.async.js:58:17)
    at jquery.async.js:29:4
    at $.whileAsync (jquery.async.js:41:4)
    at $.eachAsync (jquery.async.js:53:4)
    at $.fn.eachAsync (jquery.async.js:65:4)
    at Object.load (ext.smw.js:288:14)
    at ext.srf.formats.tagcloud.js:234:17

There was also an open PR on #978 but that had ALOT of changes which aren't necessary. This is minor.

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.09%. Comparing base (63b4313) to head (15d4f07).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #981   +/-   ##
=========================================
  Coverage     45.09%   45.09%           
  Complexity     2422     2422           
=========================================
  Files            81       81           
  Lines          9196     9196           
=========================================
  Hits           4147     4147           
  Misses         5049     5049           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YOUR1
Copy link
Contributor Author

YOUR1 commented Nov 28, 2025

Pinging @gesinn-it-ilm, since he was the original author of the D3 V6 update.

@jaideraf jaideraf merged commit 595748c into SemanticMediaWiki:master Jan 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants