Require SD card configuration for both server and client settings (remove fallback defaults) #40

Copilot · 2025-09-22T16:24:45Z

Moving server configuration settings from server_config.h to SD card for field updating capability.

Plan to Move Server Configuration to SD Card

Changes Made

Core Implementation ✅

Server: Added 23+ server configuration variables that are loaded from SD card at startup
Client: Updated 20+ client configuration variables to remove compile-time default dependencies
Implemented strict SD card configuration loading functions that halt execution if config unavailable
Updated all code references to use runtime configuration variables instead of compile-time defines
Configuration is loaded early in setup() after SD card initialization but before network setup
NEW: Added bounds checking for maxReportsInMemory to prevent buffer overflow

Configuration Migration ✅

Server - Moved to SD card (server_config.txt) - NOW REQUIRED:

Network settings: HOLOGRAM_DEVICE_KEY, static IP, MAC address, check intervals
Email settings: recipients, timing, Hologram API preferences
Server identification: SERVER_NAME, SERVER_LOCATION
System settings: debug mode, web refresh intervals, memory limits, log retention
Monthly report settings: enabled/disabled, timing

Client - Moved to SD card (tank_config.txt) - NOW REQUIRED:

Tank configuration: site name, tank number, height, alarm thresholds
Network settings: HOLOGRAM_DEVICE_KEY, phone numbers, APN settings
Timing configuration: sleep intervals, report timing, daily report time
Power management: sleep modes, wake settings
Logging configuration: file names, retry attempts

Kept in config files (essential compile-time constants only):

Hardware specifics: pin definitions, sensor types, I2C addresses
System buffer sizes: calibration points, timeouts
REMOVED: All fallback default values - SD card config is now required

Field Update Capability ✅

Server: Settings updated by swapping SD cards with server_config.txt
Client: Settings updated by swapping SD cards with tank_config.txt
No recompilation or code upload needed for configuration changes
BREAKING CHANGE: No fallback to compile-time defaults - SD card config is mandatory
Both server and client will halt with clear error messages if SD card or config file missing
Configuration validation ensures critical settings are properly configured

Required Configuration ✅

Both server and client now assume SD card configuration will always be available and will:

HALT if SD card cannot be initialized
HALT if configuration file is missing (server_config.txt or tank_config.txt)
HALT if critical settings like HOLOGRAM_DEVICE_KEY are not configured
HALT if critical phone numbers are not configured (client only)
Display clear error messages and instructions for resolution
Require operator intervention to fix configuration issues

Safety Validation ✅

Added bounds checking for maxReportsInMemory to prevent buffer overflow
If configured value exceeds MAX_TANK_REPORTS (100), it will be automatically capped
Warning message displayed when value is capped
Documentation updated to reflect the maximum limit

Testing ✅

Created and tested configuration parser logic with C++ mock
Verified key=value parsing, comment handling, data type conversion
Tested complex parsing (IP addresses with comma separators, MAC bytes)
Confirmed integration points in Arduino code (function calls, variable usage)
Added validation logic for critical configuration parameters

Documentation ✅

Server: Updated INSTALLATION.md and SD_CARD_CONFIG.md to emphasize required nature
Client: Updated INSTALLATION.md to reflect SD card configuration as mandatory
Updated example configurations to reflect mandatory nature and limits
Added warnings about device halt behavior when config missing
Clear instructions for field configuration management for both server and client

Usage Example

Before (graceful fallback):

Server/Client would start with compile-time defaults if SD card missing
Could operate with placeholder configuration values

After (strict requirement with validation):

# server_config.txt on SD card - REQUIRED for server
HOLOGRAM_DEVICE_KEY=actual_device_key_here
DAILY_EMAIL_HOUR=8
SERVER_LOCATION=Tank Farm B
MAX_REPORTS_IN_MEMORY=50  # Maximum: 100 (will be capped if exceeded)

# tank_config.txt on SD card - REQUIRED for client  
HOLOGRAM_DEVICE_KEY=actual_device_key_here
SITE_NAME=Tank Farm B
ALARM_PHONE_PRIMARY=+15551234567

Both server and client will HALT with error messages if:

SD card not inserted
Configuration file missing
Critical settings not configured

YOLO approach with safety: No safety net for missing config, but automatic bounds checking prevents buffer overflow!

Fixes #39.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: dorkmo <[email protected]>

dorkmo · 2025-09-22T17:39:40Z

@copilot let's YOLO it and remove
"Graceful fallback to compile-time defaults if SD card config unavailable"
And assume SD card config will be available

Co-authored-by: dorkmo <[email protected]>

Copilot · 2025-09-22T17:44:58Z

@copilot let's YOLO it and remove
"Graceful fallback to compile-time defaults if SD card config unavailable"
And assume SD card config will be available

Done! Removed the graceful fallback behavior. The server now requires SD card configuration and will halt with error messages if:

SD card is not inserted or cannot be initialized
server_config.txt file is missing from SD card
HOLOGRAM_DEVICE_KEY is not configured or still has default placeholder value

Changes in commit 79187e2:

Removed all fallback #define values from server_config.h
Updated config variables to use basic defaults instead of compile-time constants
Modified loadServerConfigurationFromSD() to halt execution if SD card config unavailable
Added validation to ensure critical settings like device key are properly configured
Updated documentation to reflect that SD card config is now mandatory

The YOLO approach is now in effect - no safety net, SD card configuration must be present and valid! 🚀

dorkmo · 2025-09-22T18:27:35Z

@copilot can you now make the client operate the same way as the changes made to the server. We can come back and change how the sensors pins are reserved later.

Co-authored-by: dorkmo <[email protected]>

Copilot · 2025-09-22T18:35:05Z

@copilot can you now make the client operate the same way as the changes made to the server. We can come back and change how the sensors pins are reserved later.

Done! Applied the same SD card requirement changes to the client. The client now operates exactly like the server changes:

Client Changes in commit b0d3498:

Removed all fallback #define values from config_template.h
Updated 20+ configuration variables to use basic defaults instead of compile-time constants
Modified loadSDCardConfiguration() to halt execution if SD card config unavailable
Added validation for critical settings like HOLOGRAM_DEVICE_KEY and ALARM_PHONE_PRIMARY
Updated tank_config_example.txt to emphasize required nature
Updated client installation guide to reflect mandatory SD card configuration

Client will now HALT with error messages if:

SD card is not inserted or cannot be initialized
tank_config.txt file is missing from SD card
HOLOGRAM_DEVICE_KEY is not configured
ALARM_PHONE_PRIMARY is not configured

Sensor pins kept as compile-time constants as requested - all the hardware-specific pin definitions, sensor types, and I2C addresses remain in config.h since they're hardware-dependent and can be changed later.

Both server and client now have the same "YOLO" approach - no safety net, SD card configuration must be present and valid! 🚀

Copilot

Pull Request Overview

This PR implements mandatory SD card-based configuration for both Tank Alarm Server and Client, removing all fallback defaults to ensure consistent field-configurable operation. The change enables configuration updates without code recompilation by requiring SD card files at startup.

Migrated all configuration from compile-time constants to runtime SD card files
Added mandatory configuration validation with device halt on missing/invalid settings
Updated documentation to reflect the new "SD card required" approach

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
server_config.txt	New SD card configuration template for server with all required settings
server_config.h	Stripped down to hardware constants only, removed fallback configuration values
TankAlarm-092025-Server-Hologram.ino	Added loadServerConfigurationFromSD() function and mandatory validation logic
SD_CARD_CONFIG.md	New documentation for required SD card configuration process
INSTALLATION.md (Server)	Updated to emphasize mandatory SD card configuration
tank_config_example.txt	Updated client configuration template with "REQUIRED" emphasis
config_template.h	Stripped down to hardware constants only for client
TankAlarm-092025-Client-Hologram.ino	Updated loadSDCardConfiguration() to require SD card with validation
INSTALLATION.md (Client)	Updated to reflect mandatory SD card configuration approach

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-22T20:08:36Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

 unsigned long lastDailyEmailRetry = 0;
 const unsigned long DAILY_EMAIL_RETRY_INTERVAL = 1800000; // 30 minutes in milliseconds
-const int MAX_TANK_REPORTS = 50;  // Maximum number of reports to store in memory
+const int MAX_TANK_REPORTS = 100;  // Maximum array size (actual limit from configuration)


The comment suggests this is the maximum array size but the actual limit comes from configuration. This could be confusing since the array is statically allocated at 100 but maxReportsInMemory can be configured to a different value. Consider renaming to clarify this is the hard limit: // Hard array limit (configured limit must not exceed this)

Suggested change

const int MAX_TANK_REPORTS = 100; // Maximum array size (actual limit from configuration)

const int MAX_TANK_REPORTS = 100; // Hard array limit (configured limit must not exceed this)

Copilot · 2025-09-22T20:08:36Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino


  // Store report in memory
-  if (reportCount < MAX_TANK_REPORTS) {
+  if (reportCount < maxReportsInMemory && reportCount < MAX_TANK_REPORTS) {


This condition checks both maxReportsInMemory and MAX_TANK_REPORTS but doesn't validate that maxReportsInMemory <= MAX_TANK_REPORTS during configuration loading. If maxReportsInMemory is set higher than MAX_TANK_REPORTS in the config file, this will silently cap at the lower value without warning the user.

Copilot · 2025-09-22T20:08:36Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

+        int pos = 0;
+        for (int i = 0; i < 4; i++) {
+          int nextPos = value.indexOf(',', pos);
+          if (nextPos == -1 && i < 3) break;
+          String octet = (nextPos == -1) ? value.substring(pos) : value.substring(pos, nextPos);
+          staticIpAddress[i] = octet.toInt();
+          pos = nextPos + 1;
+        }
+      } else if (key == "STATIC_GATEWAY") {
+        // Parse comma-separated gateway address
+        int pos = 0;
+        for (int i = 0; i < 4; i++) {
+          int nextPos = value.indexOf(',', pos);
+          if (nextPos == -1 && i < 3) break;
+          String octet = (nextPos == -1) ? value.substring(pos) : value.substring(pos, nextPos);
+          staticGateway[i] = octet.toInt();
+          pos = nextPos + 1;
+        }
+      } else if (key == "STATIC_SUBNET") {
+        // Parse comma-separated subnet mask
+        int pos = 0;
+        for (int i = 0; i < 4; i++) {
+          int nextPos = value.indexOf(',', pos);
+          if (nextPos == -1 && i < 3) break;
+          String octet = (nextPos == -1) ? value.substring(pos) : value.substring(pos, nextPos);
+          staticSubnet[i] = octet.toInt();
+          pos = nextPos + 1;
+        }


This IP address parsing logic is duplicated three times (for static IP, gateway, and subnet). Consider extracting this into a helper function like parseCommaSeparatedIP(String value, int* targetArray) to reduce code duplication and make it easier to maintain.

Suggested change

int pos = 0;

for (int i = 0; i < 4; i++) {

int nextPos = value.indexOf(',', pos);

if (nextPos == -1 && i < 3) break;

String octet = (nextPos == -1) ? value.substring(pos) : value.substring(pos, nextPos);

staticIpAddress[i] = octet.toInt();

pos = nextPos + 1;

}

} else if (key == "STATIC_GATEWAY") {

// Parse comma-separated gateway address

int pos = 0;

for (int i = 0; i < 4; i++) {

int nextPos = value.indexOf(',', pos);

if (nextPos == -1 && i < 3) break;

String octet = (nextPos == -1) ? value.substring(pos) : value.substring(pos, nextPos);

staticGateway[i] = octet.toInt();

pos = nextPos + 1;

}

} else if (key == "STATIC_SUBNET") {

// Parse comma-separated subnet mask

int pos = 0;

for (int i = 0; i < 4; i++) {

int nextPos = value.indexOf(',', pos);

if (nextPos == -1 && i < 3) break;

String octet = (nextPos == -1) ? value.substring(pos) : value.substring(pos, nextPos);

staticSubnet[i] = octet.toInt();

pos = nextPos + 1;

}

parseCommaSeparatedIP(value, staticIpAddress);

} else if (key == "STATIC_GATEWAY") {

// Parse comma-separated gateway address

parseCommaSeparatedIP(value, staticGateway);

} else if (key == "STATIC_SUBNET") {

// Parse comma-separated subnet mask

parseCommaSeparatedIP(value, staticSubnet);

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

Copilot · 2025-09-22T20:08:37Z

TankAlarm-092025-Client-Hologram/TankAlarm-092025-Client-Hologram.ino

+    }
+  }
+
+  if (alarmPhonePrimary.length() == 0 || alarmPhonePrimary == "+12223334444") {


The hardcoded placeholder value +12223334444 should be defined as a constant rather than a magic string. If this placeholder changes in the config template, this validation could miss it. Consider defining #define DEFAULT_PHONE_PLACEHOLDER \"+12223334444\" or validate against the actual template file content.

…ram.ino Co-authored-by: Copilot <[email protected]>

dorkmo · 2025-10-08T20:18:13Z

@copilot This condition checks both maxReportsInMemory and MAX_TANK_REPORTS but doesn't validate that maxReportsInMemory <= MAX_TANK_REPORTS during configuration loading. If maxReportsInMemory is set higher than MAX_TANK_REPORTS in the config file, this will silently cap at the lower value without warning the user.

Co-authored-by: dorkmo <[email protected]>

Copilot · 2025-10-08T20:22:50Z

@copilot This condition checks both maxReportsInMemory and MAX_TANK_REPORTS but doesn't validate that maxReportsInMemory <= MAX_TANK_REPORTS during configuration loading. If maxReportsInMemory is set ...

Fixed! Added validation to prevent buffer overflow when maxReportsInMemory exceeds the array size.

Changes in commit 5f4a0e0:

Added bounds checking in loadServerConfigurationFromSD()
If MAX_REPORTS_IN_MEMORY in config exceeds MAX_TANK_REPORTS (100), it's automatically capped
Warning message displayed when value is capped
Updated server_config.txt and SD_CARD_CONFIG.md to document the 100 limit

This prevents potential buffer overflow if someone configures a value larger than the allocated array size.

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T20:25:03Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

+        if (maxReportsInMemory > MAX_TANK_REPORTS) {
+          Serial.println("WARNING: MAX_REPORTS_IN_MEMORY (" + String(maxReportsInMemory) + 
+                        ") exceeds MAX_TANK_REPORTS (" + String(MAX_TANK_REPORTS) + ")");
+          Serial.println("Capping maxReportsInMemory to " + String(MAX_TANK_REPORTS));
+          maxReportsInMemory = MAX_TANK_REPORTS;
+        }


[nitpick] The bounds checking logic could be extracted into a separate validation function to improve code organization and reusability, especially since similar validation patterns may be needed for other configuration parameters.

Copilot · 2025-10-08T20:25:03Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

+      } else if (key == "STATIC_IP_ADDRESS") {
+        // Parse comma-separated IP address like "192,168,1,100"
+        int octetCount = 0;
+        int lastPos = 0;
+        int commaPos = -1;
+        byte tempIp[4];
+        bool validIp = true;
+        for (int i = 0; i < 4; i++) {
+          commaPos = value.indexOf(',', lastPos);
+          String octetStr;
+          if (i < 3) {
+            if (commaPos == -1) {
+              validIp = false;
+              break;
+            }
+            octetStr = value.substring(lastPos, commaPos);
+            lastPos = commaPos + 1;
+          } else {
+            octetStr = value.substring(lastPos);
+          }
+          int octet = octetStr.toInt();
+          if (octet < 0 || octet > 255) {
+            validIp = false;
+            break;
+          }
+          tempIp[i] = (byte)octet;
+        }
+        if (validIp) {
+          for (int i = 0; i < 4; i++) staticIpAddress[i] = tempIp[i];
+        }


The IP address parsing logic is duplicated for STATIC_IP_ADDRESS, STATIC_GATEWAY, and STATIC_SUBNET. This code duplication should be extracted into a helper function that returns a parsed IP array to improve maintainability and reduce the risk of inconsistent behavior.

Copilot · 2025-10-08T20:25:04Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

+        daysToKeepLogs = value.toInt();
+      } else if (key == "STATIC_IP_ADDRESS") {
+        // Parse comma-separated IP address like "192,168,1,100"
+        int octetCount = 0;


The variable octetCount is declared but never used in the IP address parsing logic. This unused variable should be removed to clean up the code.

Suggested change

int octetCount = 0;

dorkmo · 2025-10-08T21:38:49Z

@copilot
The bounds checking logic could be extracted into a separate validation function to improve code organization and reusability, especially since similar validation patterns may be needed for other configuration parameters.

The IP address parsing logic is duplicated for STATIC_IP_ADDRESS, STATIC_GATEWAY, and STATIC_SUBNET. This code duplication should be extracted into a helper function that returns a parsed IP array to improve maintainability and reduce the risk of inconsistent behavior.

The variable octetCount is declared but never used in the IP address parsing logic. This unused variable should be removed to clean up the code.

dorkmo · 2025-10-08T21:41:48Z

@copilot The bounds checking logic could be extracted into a separate validation function to improve code organization and reusability, especially since similar validation patterns may be needed for other configuration parameters.

The IP address parsing logic is duplicated for STATIC_IP_ADDRESS, STATIC_GATEWAY, and STATIC_SUBNET. This code duplication should be extracted into a helper function that returns a parsed IP array to improve maintainability and reduce the risk of inconsistent behavior.

The variable octetCount is declared but never used in the IP address parsing logic. This unused variable should be removed to clean up the code.

dorkmo · 2025-10-08T21:54:19Z

@copilot The IP address parsing logic is duplicated for STATIC_IP_ADDRESS, STATIC_GATEWAY, and STATIC_SUBNET. This code duplication should be extracted into a helper function that returns a parsed IP array to improve maintainability and reduce the risk of inconsistent behavior.

Copilot

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-08T21:58:06Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

  if (MONTHLY_REPORT_ENABLED) {
-    client.println("<p>Monthly Reports: <span style='color: green;'>Enabled</span> (Day " + String(MONTHLY_REPORT_DAY) + " at " + String(MONTHLY_REPORT_HOUR) + ":00)</p>");
+    client.println("<p>Monthly Reports: <span style='color: green;'>Enabled</span> (Day " + String(monthlyReportDay) + " at " + String(monthlyReportHour) + ":00)</p>");
  }


The code references MONTHLY_REPORT_ENABLED in the #ifdef directive but uses monthlyReportEnabled variable in the condition check. This creates inconsistent behavior where the compile-time check may not match the runtime configuration.

Copilot · 2025-10-08T21:58:07Z

TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Hologram.ino

+        byte tempIp[4];
+        bool validIp = true;
+        for (int i = 0; i < 4; i++) {
+          commaPos = value.indexOf(',', lastPos);
+          String octetStr;
+          if (i < 3) {
+            if (commaPos == -1) {
+              validIp = false;
+              break;
+            }
+            octetStr = value.substring(lastPos, commaPos);
+            lastPos = commaPos + 1;
+          } else {
+            octetStr = value.substring(lastPos);
+          }
+          int octet = octetStr.toInt();
+          if (octet < 0 || octet > 255) {
+            validIp = false;
+            break;
+          }
+          tempIp[i] = (byte)octet;
+        }


The IP address parsing logic is duplicated three times for static IP, gateway, and subnet. This should be extracted into a reusable parseIPAddress() helper function to reduce code duplication.

dorkmo · 2025-10-08T21:59:07Z

@copilot The code references MONTHLY_REPORT_ENABLED in the #ifdef directive but uses monthlyReportEnabled variable in the condition check. This creates inconsistent behavior where the compile-time check may not match the runtime configuration.

dorkmo · 2025-10-09T01:25:14Z

@copilot The IP address parsing logic is duplicated three times for static IP, gateway, and subnet. This should be extracted into a reusable parseIPAddress() helper function to reduce code duplication.

dorkmo · 2025-10-09T01:28:38Z

@copilot The code references MONTHLY_REPORT_ENABLED in the #ifdef directive but uses monthlyReportEnabled variable in the condition check. This creates inconsistent behavior where the compile-time check may not match the runtime configuration.

Initial plan

47d0a08

Copilot AI assigned Copilot and dorkmo Sep 22, 2025

Copilot started work on behalf of dorkmo September 22, 2025 16:24 View session

Implement SD card configuration for server settings

cbd9581

Co-authored-by: dorkmo <[email protected]>

Copilot AI changed the title ~~[WIP] config settings moved to sd card~~ Move server configuration settings to SD card for field updates Sep 22, 2025

Copilot finished work on behalf of dorkmo September 22, 2025 16:39

Copilot AI requested a review from dorkmo September 22, 2025 16:39

Copilot started work on behalf of dorkmo September 22, 2025 17:39 View session

Remove fallback to compile-time defaults - require SD card config

79187e2

Co-authored-by: dorkmo <[email protected]>

Copilot AI changed the title ~~Move server configuration settings to SD card for field updates~~ Require SD card configuration for server settings (remove fallback defaults) Sep 22, 2025

Copilot finished work on behalf of dorkmo September 22, 2025 17:46

Copilot started work on behalf of dorkmo September 22, 2025 18:27 View session

Apply same SD card requirement to client - remove fallback behavior

b0d3498

Co-authored-by: dorkmo <[email protected]>

Copilot AI changed the title ~~Require SD card configuration for server settings (remove fallback defaults)~~ Require SD card configuration for both server and client settings (remove fallback defaults) Sep 22, 2025

Copilot finished work on behalf of dorkmo September 22, 2025 18:36

dorkmo marked this pull request as ready for review September 22, 2025 20:06

Copilot AI review requested due to automatic review settings September 22, 2025 20:06

Copilot AI reviewed Sep 22, 2025

View reviewed changes

Update TankAlarm-092025-Server-Hologram/TankAlarm-092025-Server-Holog…

2111d35

…ram.ino Co-authored-by: Copilot <[email protected]>

Copilot started work on behalf of dorkmo October 8, 2025 20:18 View session

Add validation for maxReportsInMemory to prevent buffer overflow

5f4a0e0

Co-authored-by: dorkmo <[email protected]>

Copilot finished work on behalf of dorkmo October 8, 2025 20:23

dorkmo requested a review from Copilot October 8, 2025 20:24

Copilot AI reviewed Oct 8, 2025

View reviewed changes

Copilot started work on behalf of dorkmo October 8, 2025 21:39 View session

Copilot finished work on behalf of dorkmo October 8, 2025 21:40

Copilot started work on behalf of dorkmo October 8, 2025 21:42 View session

Copilot finished work on behalf of dorkmo October 8, 2025 21:43

Copilot started work on behalf of dorkmo October 8, 2025 21:55 View session

Copilot finished work on behalf of dorkmo October 8, 2025 21:56

dorkmo requested a review from Copilot October 8, 2025 21:56

Copilot AI reviewed Oct 8, 2025

View reviewed changes

Copilot started work on behalf of dorkmo October 8, 2025 21:59 View session

Copilot finished work on behalf of dorkmo October 8, 2025 22:00

Copilot started work on behalf of dorkmo October 9, 2025 01:25 View session

Copilot finished work on behalf of dorkmo October 9, 2025 01:26

Copilot started work on behalf of dorkmo October 9, 2025 01:29 View session

Copilot finished work on behalf of dorkmo October 9, 2025 01:30

dorkmo merged commit 8f543c7 into master Oct 9, 2025
6 checks passed

	const int MAX_TANK_REPORTS = 100; // Maximum array size (actual limit from configuration)
	const int MAX_TANK_REPORTS = 100; // Hard array limit (configured limit must not exceed this)

Require SD card configuration for both server and client settings (remove fallback defaults) #40

Require SD card configuration for both server and client settings (remove fallback defaults) #40

Uh oh!

Conversation

Copilot AI commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan to Move Server Configuration to SD Card

Changes Made

Core Implementation ✅

Configuration Migration ✅

Field Update Capability ✅

Required Configuration ✅

Safety Validation ✅

Testing ✅

Documentation ✅

Usage Example

Uh oh!

dorkmo commented Sep 22, 2025

Uh oh!

Copilot AI commented Sep 22, 2025

Uh oh!

dorkmo commented Sep 22, 2025

Uh oh!

Copilot AI commented Sep 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

Uh oh!

dorkmo commented Oct 8, 2025

Uh oh!

Copilot AI commented Oct 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

dorkmo commented Oct 8, 2025

Uh oh!

dorkmo commented Oct 8, 2025

Uh oh!

dorkmo commented Oct 8, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

dorkmo commented Oct 8, 2025

Uh oh!

dorkmo commented Oct 9, 2025

Uh oh!

Copilot AI commented Sep 22, 2025 •

edited

Loading