Skip to content

[WIP] Fix compilation errors in Arduino project workflow #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorkmo merged 2 commits into from
Nov 12, 2025
Merged

[WIP] Fix compilation errors in Arduino project workflow #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04b9d55
Client: fix logging variables in sendDailyReportForTank (use tanks[idx])
dorkmo Nov 12, 2025
9afb324
Checkpoint from VS Code for coding agent session
dorkmo Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions TankAlarm-092025-Client-Hologram/TankAlarm-092025-Client-Hologram.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ void sendDailyReportForTank(int idx);
void logDailyDataForTank(int idx);
float readTankSensor(int tankIdx);
void updateAllTankReadings();
float convertToInches(float sensorValue, int tankIdx = 0);

// Calibration function declarations
void loadCalibrationData();
Expand Down Expand Up @@ -1103,7 +1104,7 @@ void sendDailyReportForTank(int idx) {
sendHologramData("DAILY", message);

// Log daily report event
logEvent("Daily report completed for site '" + siteName + "' tank #" + String(tankNum));
logEvent("Daily report completed for site '" + tanks[idx].siteName + "' tank #" + String(tanks[idx].tankNum));
}

void sendStartupNotification() {
Expand Down Expand Up @@ -1499,7 +1500,7 @@ void loadSDCardConfiguration() {
}

// Convert sensor reading to inches (requires tank index for height reference)
float convertToInches(float sensorValue, int tankIdx = 0) {
float convertToInches(float sensorValue, int tankIdx) {
// Use calibration data if available
if (calibrationDataLoaded && numCalibrationPoints >= 2) {
return interpolateHeight(sensorValue);
Expand Down
Loading