Skip to content

Added the Weight Command#34

Open
KlaasNiphaas wants to merge 6 commits intoSenither:masterfrom
KlaasNiphaas:master
Open

Added the Weight Command#34
KlaasNiphaas wants to merge 6 commits intoSenither:masterfrom
KlaasNiphaas:master

Conversation

@KlaasNiphaas
Copy link

Just added a weight command.

Copy link
Contributor

@itsneyoa itsneyoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker won't work with the api key properties at the moment - you'll need to update docker-compose.yml and Configuration.js for that.

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.
  • Optional parameters may be helpful too, !weight [ign] [profile] where neither parameters returns the data for whoever sent the message on their last saved profile, only ign parameter returning the data for the specified ign on their last saved profile and both arguments returning the specified ign on the specified profile's data.


async function getApiData(ign) {
delete require.cache[require.resolve('../../../config.json')];
const config = require('../../../config.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break Docker support as the module will not be found, if you wanted to add to be ability to change the config without restarting the bot you'd have to add a method to the Configuration class to refresh it every time the API key is used.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in the next commit.

Copy link
Author

@KlaasNiphaas KlaasNiphaas Aug 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed i think

@KlaasNiphaas
Copy link
Author

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.

I don't fully understand this code (with all the this. and classes) but i'll try.

@KlaasNiphaas
Copy link
Author

A few suggestions:

  • In order to make adding new commands easier to add, it may be worth putting all api related methods inside their own class and adding it as a property on either the App or Minecraft objects, so to get the data you could just add the line const playerData = this.minecraft.apiHandler.getPlayerData(<ign>) or something similar.

I don't fully understand this code (with all the this. and classes) but i'll try.

I tried for quite some time but i can't make it work :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants