Skip to content

Wrap disposable vector stores in using statements to prevent resource leaks #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeffreySu merged 2 commits into from
Nov 1, 2025
Merged

Wrap disposable vector stores in using statements to prevent resource leaks #161

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e52f9b
Initial plan
Copilot Nov 1, 2025
ccc71b2
Wrap disposable vector stores in using statements to ensure proper di…
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
where TRecord : class
{
IDatabase database;
VectorStore vectorStore;
VectorStoreCollection<TKey, TRecord> collection = null;

//TODO: If the logic becomes overly complex in the future, different combinations can be considered to be separated into different libraries
Expand All @@ -253,8 +252,10 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
{
case VectorDBType.Memory:
{
vectorStore = new InMemoryVectorStore();
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
using (var inMemoryVectorStore = new InMemoryVectorStore())
{
collection = inMemoryVectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
}
break;
}
case VectorDBType.HardDisk:
Expand Down Expand Up @@ -293,13 +294,17 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
}
case VectorDBType.Qdrant:
{
vectorStore = new QdrantVectorStore(new QdrantClient(vectorDb.ConnectionString), ownsClient: true);
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
using (var qdrantVectorStore = new QdrantVectorStore(new QdrantClient(vectorDb.ConnectionString), ownsClient: true))
{
collection = qdrantVectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
}
break;
}
default:
vectorStore = new InMemoryVectorStore();
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
using (var inMemoryVectorStore = new InMemoryVectorStore())
{
collection = inMemoryVectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
}
break;
}

Expand Down
Loading