Skip to content

Fix vector store disposal by retrieving from DI container #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix vector store disposal by retrieving from DI container #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da1fc89
Initial plan
Copilot Nov 1, 2025
d5b9ea1
Fix vector store disposal issue by using DI-registered instances
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,17 +243,18 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
where TKey : notnull
where TRecord : class
{
IDatabase database;
VectorStore vectorStore;
VectorStoreCollection<TKey, TRecord> collection = null;
var kernel = iWwantToRun.Kernel;

//TODO: If the logic becomes overly complex in the future, different combinations can be considered to be separated into different libraries

switch (vectorDb.Type)
{
case VectorDBType.Memory:
{
vectorStore = new InMemoryVectorStore();
// Retrieve from DI container (registered via ConfigVectorStore)
vectorStore = kernel.Services.GetRequiredService<VectorStore>();
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
break;
}
Expand All @@ -263,12 +264,9 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
}
case VectorDBType.Redis:
{
database = ConnectionMultiplexer.Connect(vectorDb.ConnectionString).GetDatabase();
using (var redisVectorStore = new RedisVectorStore(database,
new() { StorageType = RedisStorageType.Json }))
{
collection = redisVectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
}
// Retrieve from DI container (registered via ConfigVectorStore)
vectorStore = kernel.Services.GetRequiredService<VectorStore>();
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
break;
}
case VectorDBType.Milvus:
Expand All @@ -293,12 +291,14 @@ public static VectorStoreCollection<TKey, TRecord> GetVectorCollection<TKey, TRe
}
case VectorDBType.Qdrant:
{
vectorStore = new QdrantVectorStore(new QdrantClient(vectorDb.ConnectionString), ownsClient: true);
// Retrieve from DI container (registered via ConfigVectorStore)
vectorStore = kernel.Services.GetRequiredService<VectorStore>();
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
break;
}
default:
vectorStore = new InMemoryVectorStore();
// For unsupported types, try to get from DI or throw an error
vectorStore = kernel.Services.GetRequiredService<VectorStore>();
collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);
break;
}
Expand Down
Loading