Skip to content

Fix Docker documentation to use environment variables#9

Merged
michaelmoore-s1 merged 1 commit intomainfrom
8-docker-documentation-is-incorrect
Nov 9, 2025
Merged

Fix Docker documentation to use environment variables#9
michaelmoore-s1 merged 1 commit intomainfrom
8-docker-documentation-is-incorrect

Conversation

@michaelmoore-s1
Copy link
Contributor

Fixes #8

Changes

Docker examples incorrectly showed CLI arguments (--mode, --host, --port) which are silently ignored by the entrypoint script.

Updated documentation to use environment variables instead:

  • MCP_MODE for transport mode
  • MCP_HOST for bind address
  • MCP_PORT for bind port

Files Changed

  • README.md: Updated Quick Start Docker example
  • DOCKER.md: Updated all docker run examples and added note about environment variables vs CLI arguments

Docker examples incorrectly showed CLI arguments (--mode, --host, --port)
which are silently ignored by the entrypoint script. Updated all examples
to use MCP_MODE, MCP_HOST, and MCP_PORT environment variables instead.
@michaelmoore-s1 michaelmoore-s1 linked an issue Nov 9, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

AI Analysis

Here are some suggestions to consider:

  • Thanks for tightening up the Docker docs—the new guidance to use MCP_MODE/MCP_HOST/MCP_PORT env vars matches how the entrypoint actually launches the server, so users no longer get misled by CLI flags that the container ignores. Looks good from my end.

These suggestions are generated by gpt-5-codex as an experimental capability. It may make mistakes. You do not need to follow all these suggestions.

@michaelmoore-s1 michaelmoore-s1 merged commit 87ec85d into main Nov 9, 2025
14 checks passed
@michaelmoore-s1 michaelmoore-s1 deleted the 8-docker-documentation-is-incorrect branch November 9, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker documentation is incorrect

1 participant