Remove version tracking for local Docker builds, use :latest tag #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phrocker
requested changes
Oct 10, 2025
| ### Want to use specific versions locally | ||
|
|
||
| If you need specific versions for local testing, you can manually override: | ||
| ```bash |
Contributor
There was a problem hiding this comment.
is telling people to manually override in the script the best idea?
Contributor
Author
There was a problem hiding this comment.
You're right, that wasn't ideal. I've updated the approach to use environment variable overrides instead:
# Override versions without editing the script
SENTRIUS_VERSION="1.2.3" ./ops-scripts/local/deploy-helm.shThe script now uses ${VAR:-default} pattern so users can override any version via environment variables. Updated in commit 7bb8e30.
Copilot
AI
changed the title
[WIP] Remove reliance on env files for version tracking
Remove version tracking for local Docker builds, use :latest tag
Oct 10, 2025
Contributor
|
@copilot left a comment |
- Modified build-images.sh to use :latest for local builds - Updated deploy-helm.sh to use :latest instead of reading .local.env - Added deprecation notes to .env and .local.env files - Updated .gitignore to properly handle .env backup files - GCP builds still use version tracking via .gcp.env Co-authored-by: phrocker <[email protected]>
Co-authored-by: phrocker <[email protected]>
- Modified deploy-helm.sh to use ${VAR:-default} pattern
- Users can now override versions via environment variables
- Updated docs to recommend env vars instead of script editing
- Addresses feedback about manual script modification
Co-authored-by: phrocker <[email protected]>
phrocker
force-pushed
the
copilot/remove-env-file-reliance
branch
from
0993e5b to
33a58c9
Compare
phrocker
added a commit
that referenced
this pull request
Nov 27, 2025
* Initial plan * Fix sidebar menu collapse by removing accordion behavior Co-authored-by: phrocker <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: phrocker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Successfully removed reliance on .env files for local development version tracking:
Changes Made:
:latesttag for all local builds, only tracks versions for GCPBenefits:
Original prompt
Fixes #106
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.