LibWeb: Implement window.length#15103
Merged
linusg merged 2 commits intoSerenityOS:masterfrom Sep 9, 2022
Merged
Conversation
linusg
reviewed
Sep 2, 2022
networkException
force-pushed
the
window-length
branch
from
2e4b253 to
32ee55e
Compare
linusg
reviewed
Sep 2, 2022
networkException
force-pushed
the
window-length
branch
2 times, most recently
from
3a59464 to
123fcb9
Compare
networkException
force-pushed
the
window-length
branch
from
123fcb9 to
94767cf
Compare
Member
Author
|
I've changed the call to |
linusg
reviewed
Sep 9, 2022
This patch makes use of helpers implemented for window.length to resolve two FIXMEs in WindowProxy previously simply assuming no child browsing contexts :^)
networkException
force-pushed
the
window-length
branch
from
94767cf to
91f9a11
Compare
networkException
changed the title
window.length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After seeing people have fun with the web on twitter I thought we could also partake in the fun and gain a bit of spec compliance in the process :^)