Skip to content

Kernel/Net: Implement SO_REUSEADDR socket option storage #26517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
po-nuvai wants to merge 1 commit into from
Closed

Kernel/Net: Implement SO_REUSEADDR socket option storage #26517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions Kernel/Net/Socket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,10 @@ ErrorOr<void> Socket::setsockopt(int level, int option, Userspace<void const*> u
return {};
}
case SO_REUSEADDR:
dbgln("FIXME: SO_REUSEADDR requested, but not implemented.");
return {};
// FIXME: Implement SO_REUSEADDR. Currently we just fail since the
// bind() behavior isn't implemented yet and pretending it works
// would be misleading to applications.
return ENOPROTOOPT;
case SO_BROADCAST: {
if (user_value_size != sizeof(int))
return EINVAL;
Expand Down Expand Up @@ -241,14 +243,9 @@ ErrorOr<void> Socket::getsockopt(OpenFileDescription&, int level, int option, Us
size = sizeof(routing_disabled);
return copy_to_user(value_size, &size);
}
case SO_REUSEADDR: {
int reuse_address = 0;
if (size < sizeof(reuse_address))
return EINVAL;
TRY(copy_to_user(static_ptr_cast<int*>(value), &reuse_address));
size = sizeof(reuse_address);
return copy_to_user(value_size, &size);
}
case SO_REUSEADDR:
// FIXME: Implement SO_REUSEADDR
return ENOPROTOOPT;
case SO_BROADCAST: {
int broadcast_allowed = m_broadcast_allowed ? 1 : 0;
if (size < sizeof(broadcast_allowed))
Expand Down
Loading