LibC: Clean up stub function debug output and return values #26520
+29
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace dbgln() calls in stub functions with FIXME comments to reduce runtime noise. Also fix incorrect return values: - fnmatch(): Return FNM_NOMATCH instead of 0 (which indicates match) - ulimit(): Return -1 with errno=ENOSYS instead of calling TODO() - priority: Set errno=ENOSYS for getpriority()/setpriority() - endmntent(): Return 1 per glibc documentation (always succeeds) - res_query(): Return -1 (error) instead of 0 Remove now-unused AK/Format.h includes.
github-actions
bot
added
the
👀 pr-needs-review
Contributor
|
Doesn't build. |
nico
added
⏳ pr-waiting-for-author
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dbgln()calls in stub functions with FIXME comments to reduce runtime noisefnmatch(): ReturnFNM_NOMATCHinstead of 0 (which falsely indicates a match)ulimit(): Return -1 witherrno=ENOSYSinstead of callingTODO()which panicsgetpriority()/setpriority(): Seterrno=ENOSYSfor proper error reportingendmntent(): Return 1 per glibc documentation (always succeeds)res_query(): Return -1 (error) instead of 0AK/Format.hincludes[[maybe_unused]]attribute to function parameters