WebServer: Set Content-Length: 0 header during redirection#26701
Open
tbhaxor wants to merge 1 commit intoSerenityOS:masterfrom
Open
WebServer: Set Content-Length: 0 header during redirection#26701tbhaxor wants to merge 1 commit intoSerenityOS:masterfrom
Content-Length: 0 header during redirection#26701tbhaxor wants to merge 1 commit intoSerenityOS:masterfrom
Conversation
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
reviewed
Apr 7, 2026
| @@ -228,6 +228,7 @@ ErrorOr<void> Client::send_redirect(StringView redirect_path, HTTP::HttpRequest | |||
| { | |||
Member
There was a problem hiding this comment.
Change looks good, but it would be nice to have some details in the commit description to say what is the issue that this patch is fixing and why it's fixing it. (So that clients like curl hang because they are waiting on some content.)
Also, while adding an external reference is nice, this python bug is not an authoritative source. So it should be introduced differently, something like:
The issue was fixed using the same approach in Python's http.server, see [1].
[1] the link.
(If you find a better source, like an actual specification it would be even better!)
Contributor
Author
There was a problem hiding this comment.
Actually I wanted to include such message, I am looking for citations from HTTP RFCs, so that it doesn't sound like made up thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26431
Ref: https://bugs.python.org/issue43972