Ports: Remove multilib handling from luajit#26704
Merged
spholz merged 1 commit intoSerenityOS:masterfrom Apr 7, 2026
Merged
Conversation
i686 support war removed, so there is no need to pass -m64 explicitly. Before i686 support was removed in b49c4eb, we used to pass -m32 for 32-bit systems here. Additionally, installing multilib development packages like libc6-dev-i386 should be unnecessary now, so the flashy warning message can be removed. This also makes the port compile on AArch64 now. Previously, it failed to build because M_FLAG was undefined. It still won't build on RISC-V since LuaJIT itself doesn't support RISC-V yet (LuaJIT/LuaJIT#1267).
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
added
✅ pr-maintainer-approved-but-awaiting-ci
Member
Author
|
It won't actually run on AArch64 though, as I just found out. It crashes with |
github-actions
bot
removed
the
✅ pr-maintainer-approved-but-awaiting-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i686 support war removed, so there is no need to pass -m64 explicitly. Before i686 support was removed in b49c4eb, we used to pass -m32 for 32-bit systems here.
Additionally, installing multilib development packages like libc6-dev-i386 should be unnecessary now, so the flashy warning message can be removed.
This also makes the port compile on AArch64 now. Previously, it failed to build because M_FLAG was undefined.
It still won't build on RISC-V since LuaJIT itself doesn't support RISC-V yet (LuaJIT/LuaJIT#1267).