Fy/flexible rps

[future-xy]

Summary

This PR adds support for floating-point RPS (requests per second) values in the trace generator, enabling more granular control over load testing scenarios.

Changes

• Modified SyntheticTraceGenerator to accept float RPS values
• Updated CLI to handle float RPS inputs
• Added comprehensive test coverage
• Maintained backward compatibility

Impact

• Enables testing low-throughput scenarios (e.g., 0.5 RPS)
• Provides more flexibility in test configuration
• No breaking changes to existing functionality

[Copilot]

Pull Request Overview

This PR adds support for floating-point RPS values in the trace generator, allowing more granular load testing scenarios. Key changes include:

• Updating SyntheticTraceGenerator to accept Union[int, float] for RPS and ensuring proper conversion in request count calculation.
• Modifying CLI options and argument types to handle float RPS values.
• Adding comprehensive tests to validate the float RPS behavior.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tracestorm/trace_generator.py	Updated type annotations and validation for RPS; added conversion logic for float values.
tracestorm/cli.py	Adjusted CLI options to accept float RPS and updated related type imports.
tests/test_trace_generator.py	Added tests to cover synthetic trace generation with float RPS values.
tests/test_cli.py	Added tests to verify CLI behavior with float RPS values.
tracestorm/main.py	The entire main file has been removed. Please verify if this deletion was intentional.

Comments suppressed due to low confidence (1)

tracestorm/main.py:1

• The file 'tracestorm/main.py' has been entirely removed; please confirm if this deletion was intentional as it may disrupt the CLI and overall application entry point.

Entire file removed

[Copilot]

Casting the product of rps and duration to int floors the resulting value, which may not reflect the intended rounding behavior for fractional RPS values. Consider using an alternative rounding method if preserving the fractional part's impact is desired.

Suggested change

	total_requests = int(self.rps * self.duration)
	total_duration_ms = self.duration * 1000
	total_requests = round(self.rps * self.duration)

[Copilot]

Pull Request Overview

This PR adds support for floating-point RPS values in the trace generator and CLI, allowing more granular load testing while maintaining backward compatibility. Key changes include updating the SyntheticTraceGenerator and CLI options to accept float RPS values, enhancing test coverage to validate the new behavior, and removing the main.py file.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tracestorm/trace_generator.py	Updated parameter types and error messages in SyntheticTraceGenerator for float RPS support.
tracestorm/main.py	Removed the file—ensure this change is intentional and that references to the main entry point are updated accordingly.
tracestorm/cli.py	Adjusted CLI options and create_trace_generator signature to accept float RPS values.
tests/test_trace_generator.py	Added tests verifying the behavior with float RPS values.
tests/test_cli.py	Enhanced CLI tests to cover scenarios with float RPS values.

Comments suppressed due to low confidence (1)

tracestorm/main.py:1

• The removal of tracestorm/main.py is significant; please confirm that this change is intentional and that any dependencies or references to this entry point are updated accordingly.

<entire file removed>

[XuehengWang]

Looks good!