Skip to content

fix: duplicated layer construct #53 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ServerlessLife merged 1 commit into from
Dec 19, 2024
Merged

fix: duplicated layer construct #53 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/ServerlessSpy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,14 @@ export class ServerlessSpy extends Construct {
layer =
layer ||
new lambda.LayerVersion(this, 'Extension', {
compatibleRuntimes: [runtime],
compatibleRuntimes: [
lambda.Runtime.NODEJS_12_X,
lambda.Runtime.NODEJS_14_X,
lambda.Runtime.NODEJS_16_X,
lambda.Runtime.NODEJS_18_X,
lambda.Runtime.NODEJS_20_X,
lambda.Runtime.NODEJS_22_X,
],
compatibleArchitectures: [architecture],
code: lambda.Code.fromAsset(this.getExtensionAssetLocation()),
});
Expand Down Expand Up @@ -500,7 +507,7 @@ export class ServerlessSpy extends Construct {
func.addEventSource(new SqsEventSource(queue));
this.setupForIoT(func);
const { layer, spyWrapperPath } = this.getExtensionForRuntime(
lambda.Runtime.NODEJS_22_X,
func.runtime,
func.architecture
)!;
func.addLayers(layer);
Expand Down
2 changes: 1 addition & 1 deletion test/cdk/src/lambdaStack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export class LambdaStack extends Stack {
const func = new NodejsFunction(this, 'MyLambda', {
memorySize: 512,
timeout: Duration.seconds(5),
runtime: lambda.Runtime.NODEJS_22_X,
runtime: lambda.Runtime.NODEJS_20_X, // older version to test
handler: 'handler',
entry: path.join(__dirname, '../functions/lambda.ts'),
environment: {
Expand Down
Loading