Daterange

[ipaksc]

No description provided.

[GormFrank]

@ipaksc Thank you for opening a PR! I did a review and there are changes required.

[GormFrank]

@ipaksc Can you also include the cases where there would only be a startdate provided, and when there is only an enddate provided?

[ipaksc]

Done

[igkislev]

1. i would
   replace

		if ( urlParams.startdate ) {
			aqString += ' @date = "' + urlParams.startdate.replaceAll('-','/') + '..' + currentDate() + '"';
		}

with

		if ( urlParams.startdate ) {
			aqString += ' @date >="' + urlParams.startdate.replaceAll('-','/')  + '"';
		}

2. shouldn't the enddate be inclusuve

		if ( urlParams.enddate ) {
			aqString += ' @date  <=  "' + urlParams.enddate.replaceAll('-','/') + '"';
		}

[GormFrank]

@ipaksc What are you trying to accomplish exactly here? What's happening at the source that forces you to change the single quote to its HTML entity instead? Then, please evaluate if the code needs to be adapted, or if it should be the source instead.

If it's the source, then let's try to keep this as generic and flexible as possible, by determining if the source would ALWAYS have ' instead of '; and if that's the case then you should simply do a something like this instead of an IF condition:

Suggested change

	if( declaredtype === "documents d'information" ){
	declaredtype = "documents d'information";
	}
	declaredtype = declaredtype.replace( /'/g, ''' );

[ipaksc]

changed

[ipaksc]

@GormFrank The request comes as "documents d'information" we have to match "documents d'information" in the index or the filter will not work.

[ipaksc]

PR #49 supersedes this one, so I am going to close this pull request.