Skip to content

Conversation

@recursix
Copy link
Collaborator

@recursix recursix commented Jun 16, 2025

Description by Korbit AI

What change is being made?

Update the viewport dimensions in the Miniwob benchmark from {"width": 333, "height": 213} to {"width": 332, "height": 214}.

Why are these changes being made?

This change is intended to adjust the viewport scaling for better compatibility with the Claude-3.5 model, as the previous dimensions may not be optimal for other visual language models (VLMs). Although it is a minor adjustment, it aims to improve the benchmark performance and maintain the desired aspect ratio.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this kitten.

    |\__/,|   (`\
  _.|o o  |_   ) )
-(((---(((--------
Files scanned
File Path Reviewed
browsergym/core/src/browsergym/core/init.py
browsergym/miniwob/src/browsergym/miniwob/base.py
browsergym/core/src/browsergym/core/action/utils.py
browsergym/core/src/browsergym/core/action/highlevel.py
browsergym/core/src/browsergym/core/action/functions.py
browsergym/core/src/browsergym/core/observation.py
browsergym/experiments/src/browsergym/experiments/loop.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@amanjaiswal73892 amanjaiswal73892 self-requested a review June 16, 2025 18:45
@amanjaiswal73892 amanjaiswal73892 merged commit e73ffd1 into main Jun 16, 2025
13 checks passed
@amanjaiswal73892 amanjaiswal73892 deleted the miniwob-zoom branch June 16, 2025 18:46
layahaasini pushed a commit to layahaasini/BrowserGym that referenced this pull request Nov 21, 2025
* Set device scale factor to 1.0 in extract_screenshot for consistent rendering. This prevens screenshot sized to be affected by environments such as "retina" on macbook

* add examples to the description

* zoom miniwob 150% by default (doesn't change the viewport, just has a better usage of the viewport)

* adjust version

* Update extract_screenshot to use actual window dimensions for device metrics

* Enhance zoom functionality in miniwob for better viewport usage and precision in visual agents

* Enhance zoom_page docstring with detailed explanation of CSS transform scaling benefits

* Adjust zoom factor in miniwob to improve viewport usage and precision for visual agents

* adding type

* Remap the coordinate actions based on the zoom factor

* apply the zooming at the screenshot level

* changing the zoom method

* Fix viewport dimensions for consistency in Miniwob tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants