-
Notifications
You must be signed in to change notification settings - Fork 143
Miniwob zoom #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Miniwob zoom #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endering. This prevens screenshot sized to be affected by environments such as "retina" on macbook
… better usage of the viewport)
…recision in visual agents
…m scaling benefits
… for visual agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues... but I did find this kitten.
|\__/,| (`\
_.|o o |_ ) )
-(((---(((--------Files scanned
| File Path | Reviewed |
|---|---|
| browsergym/core/src/browsergym/core/init.py | ✅ |
| browsergym/miniwob/src/browsergym/miniwob/base.py | ✅ |
| browsergym/core/src/browsergym/core/action/utils.py | ✅ |
| browsergym/core/src/browsergym/core/action/highlevel.py | ✅ |
| browsergym/core/src/browsergym/core/action/functions.py | ✅ |
| browsergym/core/src/browsergym/core/observation.py | ✅ |
| browsergym/experiments/src/browsergym/experiments/loop.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
amanjaiswal73892
approved these changes
Jun 16, 2025
layahaasini
pushed a commit
to layahaasini/BrowserGym
that referenced
this pull request
Nov 21, 2025
* Set device scale factor to 1.0 in extract_screenshot for consistent rendering. This prevens screenshot sized to be affected by environments such as "retina" on macbook * add examples to the description * zoom miniwob 150% by default (doesn't change the viewport, just has a better usage of the viewport) * adjust version * Update extract_screenshot to use actual window dimensions for device metrics * Enhance zoom functionality in miniwob for better viewport usage and precision in visual agents * Enhance zoom_page docstring with detailed explanation of CSS transform scaling benefits * Adjust zoom factor in miniwob to improve viewport usage and precision for visual agents * adding type * Remap the coordinate actions based on the zoom factor * apply the zooming at the screenshot level * changing the zoom method * Fix viewport dimensions for consistency in Miniwob tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Update the viewport dimensions in the Miniwob benchmark from
{"width": 333, "height": 213}to{"width": 332, "height": 214}.Why are these changes being made?
This change is intended to adjust the viewport scaling for better compatibility with the Claude-3.5 model, as the previous dimensions may not be optimal for other visual language models (VLMs). Although it is a minor adjustment, it aims to improve the benchmark performance and maintain the desired aspect ratio.