Fix_bbox_scale #357
Merged
Fix_bbox_scale #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing scale_factor documentation ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| browsergym/experiments/src/browsergym/experiments/benchmark/configs.py | ✅ |
| browsergym/core/src/browsergym/core/observation.py | ✅ |
| browsergym/core/src/browsergym/core/env.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+630
to
+631
| scale_factor = getattr(self.page, "_bgym_scale_factor", 1.0) | ||
| extra_properties = extract_dom_extra_properties(dom, scale_factor=scale_factor) |
There was a problem hiding this comment.
Missing scale_factor documentation 
Tell me more
What is the issue?
The scale_factor parameter usage is not documented, making it unclear why and when this scaling is applied.
Why this matters
Future maintainers won't understand the purpose of _bgym_scale_factor or know when to adjust this value.
Suggested change ∙ Feature Preview
Add comment above scale_factor line:
Apply viewport scaling factor to handle high DPI displays
scale_factor = getattr(self.page, "_bgym_scale_factor", 1.0)
Provide feedback to improve future suggestions
💬 Looking for more details? Reply to this comment to chat with Korbit.
amanjaiswal73892
approved these changes
Jul 11, 2025
layahaasini
pushed a commit
to layahaasini/BrowserGym
that referenced
this pull request
Nov 21, 2025
* fix bbox scale in extra_properties and prevent extract_screenshot from clearing CDP * add the n_repeats argument to benchmark creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Add scale factor handling in the DOM property extraction and allow adjustable repetition counts in benchmark function definitions.
Why are these changes being made?
These changes are implemented to enhance the accuracy of bounding box dimensions by incorporating a scale factor into the DOM extraction process, a necessity for environments with varying resolutions. The benchmarks have been adjusted to accept a repetition count parameter, allowing for increased flexibility in testing scenarios which can enhance the benchmarking processes.