Fill->type to trigger drop down #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Inefficient Event Synchronization ▹ view | ✅ Fix detected |
 |
Silent Error Swallowing ▹ view | ✅ Fix detected |
Files scanned
| File Path | Reviewed |
|---|---|
| browsergym/core/src/browsergym/core/env.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
569
to
572
| try: | ||
| self.page.wait_for_load_state("domcontentloaded", timeout=1500) | ||
| except playwright.sync_api.Error: | ||
| pass |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+489
to
490
| time.sleep(self.pre_observation_delay) # wait for JS events to be fired | ||
| self.context.cookies() # trigger all waiting Playwright callbacks on the stack (hack, see https://playwright.dev/java/docs/multithreading) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
amanjaiswal73892
approved these changes
Jul 18, 2025
gasse
approved these changes
Jul 22, 2025
|
|
||
| # https://playwright.dev/docs/input#text-input | ||
| def fill(bid: str, value: str): | ||
| def fill(bid: str, value: str, enable_autocomplete_menu: bool = False): |
Collaborator
There was a problem hiding this comment.
Maybe trigger_autocomplete: bool would be more explicit?
gasse
approved these changes
Jul 22, 2025
layahaasini
pushed a commit
to layahaasini/BrowserGym
that referenced
this pull request
Nov 21, 2025
* fix bbox scale in extra_properties and prevent extract_screenshot from clearing CDP * add the n_repeats argument to benchmark creation * in prep of modifying dom_wait * fill function "types" the last character to trigger autocomplete in ui * reverting to old dom_wait temporarily * Revert to old behaviour as default * sneaking in this little change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description by Korbit AI
What change is being made?
Enhance the
fillfunction to optionally trigger an autocomplete menu by typing the last character and introduce a configurable delay (pre_observation_delay) in the environment to account for autocomplete menus before extracting observations. Update the test case to reflect the demo mode timing adjustments.Why are these changes being made?
The changes facilitate interaction with autocomplete fields during typing by simulating user input that triggers autocomplete menus, making automated testing and interaction more realistic. The
pre_observation_delayensures that there is a sufficient pause to allow for these menus to appear, which improves the robustness of observation extraction. These modifications reflect a need for more responsive and adaptable interaction timing in user input simulations.