Fix bug in double click#370
Merged
amanjaiswal73892 merged 3 commits intoServiceNow:mainfrom Nov 6, 2025
Merged
Conversation
There was a problem hiding this comment.
I've completed my review and didn't find any issues... but I did find this bear.
/ \.-"""-./ \
\ - - /
| o o |
\ .-'''-. /
'-\__Y__/-'
`---`Files scanned
| File Path | Reviewed |
|---|---|
| browsergym/core/src/browsergym/core/action/functions.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Collaborator
|
Ohhh wow. This is a terrible bug. I just noticed the unit test is not even implemented. I assigned @amanjaiswal73892 to this one it should be tested and merged soon. Thanks for reporting. |
90b49ac to
8397de7
Compare
Currently double click calls click, instead of double click.
7c67183 to
d9ac352
Compare
amanjaiswal73892
previously approved these changes
Nov 6, 2025
Collaborator
amanjaiswal73892
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've added a few tests.
amanjaiswal73892
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently double click calls click, instead of double click