Skip to content

Conversation

@psriramsnc
Copy link
Collaborator

@psriramsnc psriramsnc commented Oct 8, 2025

🐞 Bug Fix: Multi Auth Token Issue

🧾 Summary

Fixes the Multi Auth Token issue when mutliple URLs, auth_tokens are provided
Previously, models inconsistently used api_key and auth_token, leading to authentication mismatches.
This PR ensures consistent use of auth_token for all model configurations, improving reliability and maintainability.


💡 Impacted Features:

  • Multiple urls, auth tokens to a model in.env with | separator can be provided
  • Added Unit test case for multi token scenario.

Minor Fixes:

  • Fixed model health check issues with vllm models in UI
  • Deprecated api_key for azure_openai to make it consistent with other model types. api_key -> auth_token
  • Updated azure_openai test cases to be in line with the change.
  • YAML and documentation updates (models.yaml, model_configuration.md)

🧪 How to Test

Steps for reviewers to verify functionality:

  1. Add multiple urls, auth tokens to a model in.env with | separator.
  2. Run any task which uses this model.
  3. Data generation should leverage all model URLs, tokens provided using the type of load_balancer set.
  4. Optionally, run tests:
    make test-verbose

Screenshots (if applicable)

N/A

Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

Notes

NO CHANGES NEEDED FROM USER END

@psriramsnc psriramsnc self-assigned this Oct 8, 2025
@psriramsnc psriramsnc changed the title Fix Multi Auth Token issue [Bug] Fix Multi Auth Token issue Oct 8, 2025
@psriramsnc psriramsnc added the bug Something isn't working label Oct 8, 2025
@psriramsnc psriramsnc changed the title [Bug] Fix Multi Auth Token issue [Fix] Multi Auth Token issue Oct 9, 2025
@psriramsnc psriramsnc marked this pull request as ready for review October 9, 2025 07:10
@psriramsnc psriramsnc requested a review from a team as a code owner October 9, 2025 07:10
Copy link
Member

@zephyrzilla zephyrzilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ✅

@vipul-mittal vipul-mittal enabled auto-merge (squash) October 15, 2025 06:42
Copy link
Collaborator

@amitsnow amitsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vipul-mittal vipul-mittal merged commit 0f08c6c into main Oct 15, 2025
6 checks passed
@vipul-mittal vipul-mittal deleted the scratch/fix_multi_auth_token_issue branch October 15, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants