Skip to content

[Enhancement] Add pre-commit config #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zephyrzilla merged 7 commits into from
Oct 23, 2025
Merged

[Enhancement] Add pre-commit config #55

zephyrzilla merged 7 commits into from
Oct 23, 2025

Conversation

@zephyrzilla
Copy link
Member

@zephyrzilla zephyrzilla commented Oct 17, 2025

Summary

This PR adds dev support for pre-commit checks.

Setup

# Install dependencies (includes pre-commit as a dev dep)
poetry install

# Install Git hooks for this repo
poetry run pre-commit install
poetry run pre-commit install -t pre-push

# (optional) Warm the caches so first commit is fast
poetry run pre-commit run --all-files

Why pre-commit?

  • Fast feedback on style/format issues
  • Consistent code across contributors
  • Fewer “nit” comments in PR reviews

Checklist

  • Lint fixes and unit testing done
  • End to end task testing
  • Documentation updated

@zephyrzilla zephyrzilla requested a review from a team as a code owner October 17, 2025 04:26
@zephyrzilla zephyrzilla self-assigned this Oct 17, 2025
@zephyrzilla zephyrzilla added the enhancement New feature or request label Oct 17, 2025
psriramsnc
psriramsnc reviewed Oct 17, 2025
View reviewed changes
amitsnow
amitsnow previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@amitsnow amitsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psriramsnc psriramsnc self-requested a review October 23, 2025 06:11
psriramsnc
psriramsnc previously approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@psriramsnc psriramsnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@zephyrzilla zephyrzilla dismissed stale reviews from psriramsnc and amitsnow via dbfe67a October 23, 2025 07:10
amitsnow
amitsnow approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@amitsnow amitsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zephyrzilla zephyrzilla merged commit 3818055 into main Oct 23, 2025
6 checks passed
@zephyrzilla zephyrzilla deleted the scratch/pre-commit branch October 23, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@psriramsnc psriramsnc psriramsnc approved these changes

@amitsnow amitsnow amitsnow approved these changes

@omkar-anustoop-ai omkar-anustoop-ai omkar-anustoop-ai approved these changes

Assignees

@zephyrzilla zephyrzilla

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zephyrzilla @psriramsnc @amitsnow @omkar-anustoop-ai