Skip to content

Conversation

@raghavs046
Copy link
Contributor

@raghavs046 raghavs046 commented Oct 7, 2025

PR Description:

Pull Request Checklist

Overview

  • I have read and understood the CONTRIBUTING.md guidelines
  • My pull request has a descriptive title that accurately reflects the changes
  • I've included only files relevant to the changes described in the PR title and description
  • I've created a new branch in my forked repository for this contribution

Code Quality

  • My code is relevant to ServiceNow developers
  • My code snippets expand meaningfully on official ServiceNow documentation (if applicable)
  • I've disclosed use of ES2021 features (if applicable)
  • I've tested my code snippets in a ServiceNow environment (where possible)

Repository Structure Compliance

  • I've placed my code snippet(s) in one of the required top-level categories:
    • Core ServiceNow APIs/
    • Server-Side Components/
    • Client-Side Components/
    • Modern Development/
    • Integration/
    • Specialized Areas/
  • I've used appropriate sub-categories within the top-level categories
  • Each code snippet has its own folder with a descriptive name

Documentation

  • I've included a README.md file for each code snippet
  • The README.md includes:
    • Description of the code snippet functionality
    • Usage instructions or examples
    • Any prerequisites or dependencies
    • (Optional) Screenshots or diagrams if helpful

Restrictions

  • My PR does not include XML exports of ServiceNow records
  • My PR does not contain sensitive information (passwords, API keys, tokens)
  • My PR does not include changes that fall outside the described scope

@rohi-v rohi-v self-assigned this Oct 7, 2025
@rohi-v
Copy link
Contributor

rohi-v commented Oct 7, 2025

Hi @raghavs046

Thank you for your submission and for highlighting the case sensitivity consideration.

However, I need to clarify an important point: PAN cards are always issued in uppercase letters only

Closing this for now. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

@rohi-v rohi-v closed this Oct 7, 2025
@raghavs046
Copy link
Contributor Author

raghavs046 commented Oct 7, 2025

@rohi-v Thanks for the review.

PAN is always issued in upper case but lower case is still valid.

Example: many documents have password as combination PAN and DOB or something else, it does not force to enter PAN in upper case.

I did this enhancement to add regex identifiers (i , m ) for case sensitivity and multiple line text but if it is not valid we can discard this.

But this script is more reusable for lower case and if the requirement is specific to upper case the (i) identifier can me removed.

I am not sure what else I can change here if case sensitivity is remove to enhance this. Let me know if you have any thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants