feat: add state monitoring for external cover changes by clintongormley · Pull Request #46 · Sese-Schneider/ha-cover-time-based

clintongormley · 2026-02-17T12:07:10Z

This PR syncs the cover status with manual actions via the switch or cover entities in Home Assistant, or the physical wall switches or remote controls. In other words, If the user uses the wall switch to open or close their cover, then this module will be aware of it and will adjust its position tracker internally.

Closes #43
Depends on #45
Depends on #44

NOTE: I wouldn't recommend merging this branch yet. I provide it for you to experiment with it. The syncing works for travelling with the toggle input mode, but I'm unable to test switch/pulse and tilt. I would appreciate feedback about whether those work correctly or not

thanks

Summary

Add echo filtering, external movement detection, and state change handling to track when covers are moved externally (e.g. via physical buttons or other automations)
Increase test coverage from 66% to 99% with 126 new tests covering config flow, cover factory, base class, toggle mode, init, and state monitoring

Test plan

All 243 tests pass locally
CI passes (pytest + ruff)
Manual testing with physical cover hardware

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adds the main integration entry point that handles config entry setup, unload, and options updates. Forwards setup to the cover platform. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ry flows - Add config flow strings for setup wizard - Add options flow strings for default timing settings - Add config subentries for cover management with add/reconfigure flows - Add selector translations for device type and input mode - Include translations for travel timing and advanced settings sections - Preserve existing service translations for set_known_position and set_known_tilt_position Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Implement three flow handlers for UI-based configuration: - CoverTimeBasedConfigFlow: creates the integration entry - CoverTimeBasedOptionsFlow: edits integration-level default timing - CoverTimeBasedSubentryFlow: adds/reconfigures individual cover entities Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add three functions to support creating cover entities from config entry subentries alongside the existing YAML-based async_setup_platform: - async_setup_entry: iterates subentries to create entities and registers custom services - _get_subentry_value: resolves config values with priority from subentry data, entry options, then schema defaults - _entity_from_subentry: constructs a CoverTimeBased entity from a config subentry, handling both switch and cover device types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Drop the subentry/defaults pattern in favor of a simpler approach: each cover is its own config entry with all settings in one form. - Single page with name, entities, input mode, timing, and a collapsible advanced section - Options flow for reconfiguration with same form - Human-friendly labels and descriptions - No shared defaults — each cover is self-contained Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Step 1: device type (radio) + input mode (radio) - Step 2: entity fields shown conditionally based on device type, pulse time only shown for pulse/toggle modes - Remove name field (handled by helper framework) - Same two-step flow for options/reconfigure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add Name field to step 1, move tilt fields into collapsible "Tilt settings" section, move pulse_time to Advanced section, add full translations to translations/en.json, and move description below the name field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add deprecation warning log and repair issue when covers are configured via YAML, directing users to recreate via the UI helpers page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Use Platform enum in __init__.py - Add type annotations to async_setup_entry (HomeAssistant, ConfigEntry, AddEntitiesCallback) - Move CONF_DEVICE_TYPE/DEVICE_TYPE_* constants to cover.py to avoid magic strings - Remove misleading `adv = d` alias in _build_details_schema - Add tilt time pair validation (both or neither must be set) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Set up pytest test infrastructure with shared fixtures (make_hass, make_cover) and write characterization tests that document the exact relay command sequences for each input mode (switch, pulse, toggle, wrapped cover). Also add toggle behavior tests covering same-direction stop, idle stop guard, and direction change scenarios. These tests serve as a safety net before refactoring. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Move CoverTimeBased from cover.py to cover_base.py and add abstract _send_open, _send_close, _send_stop methods. Refactor _async_handle_command to dispatch to these abstract methods while keeping state setting and async_write_ha_state in the dispatcher. Update tests to use a concrete CoverTimeBasedTest subclass that implements the original relay logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Create five subclasses of CoverTimeBased, each implementing the _send_open/_send_close/_send_stop abstract methods for a specific input mode: - WrappedCoverTimeBased: delegates to cover.open/close/stop_cover - SwitchCoverTimeBased: abstract mid-level base for switch-controlled covers - SwitchModeCover: latching relay mode (switches stay on during movement) - PulseModeCover: momentary pulse mode (brief pulse then switch off) - ToggleModeCover: toggle mode (re-press direction to stop, overrides async_close/open/stop_cover for same-direction-stops-movement behavior) All 54 tests pass (25 original + 29 new subclass tests). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…guards from base - Add _create_cover_from_options() factory in cover.py that creates the correct subclass (WrappedCoverTimeBased, SwitchModeCover, PulseModeCover, ToggleModeCover) based on options dict - Update async_setup_entry and devices_from_config to use the factory - Clean up CoverTimeBased base class: remove device-specific params (switch entity IDs, input_mode, pulse_time, cover_entity_id) from constructor - each subclass now only accepts what it needs - Remove toggle-specific guards from base class (async_close_cover, async_open_cover, async_stop_cover, set_known_position, set_known_tilt_position) - toggle behavior now lives in ToggleModeCover - Add stop-before-direction-change to base class async_close_cover and async_open_cover (benefits all modes, not just toggle) - Move CONF_* constants to cover_base.py to eliminate deferred import in extra_state_attributes - Add -> None return type annotations to all _send_open/_send_close/ _send_stop implementations - Update all test factories to use new constructor signatures - Remove CoverTimeBasedTest from conftest; make_cover now uses the factory to create real subclasses Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…t_position Use _async_handle_command(SERVICE_STOP_COVER) instead of bare _send_stop() to ensure self._state is set and async_write_ha_state() is called. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Extract _start_movement() helper to replace 6 duplicated startup-delay patterns - Unify async_close_cover/async_open_cover into _async_move_to_endpoint(target) - Unify async_close_cover_tilt/async_open_cover_tilt into _async_move_tilt_to_endpoint(target) - Extract _handle_pre_movement_checks() and _is_movement_too_short() from set_position/set_tilt_position - Fix startup delay conflict check ordering: check before position check so direction reversal during startup delay is properly cancelled Reduces cover_base.py from 1057 to 767 lines (27% reduction). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

63 new tests covering: - Travel/tilt endpoint movement (close, open, direction changes) - Tilt-travel coupling (both directions, with/without coupling) - set_position and set_tilt_position (direction, already-at-target, endpoints) - Min movement time filtering (short moves, endpoints always allowed) - Startup delay (creation, same-direction dedup, direction-change cancellation) - Relay delay at endpoints (auto-stop, mid-point stop, cancellation) - Stop cover, set_known_position/tilt, properties, tilt constraints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Extract _calc_coupled_target() and _begin_movement() in cover_base.py to eliminate repeated coupled-calculator and start-movement patterns across _async_move_to_endpoint, _async_move_tilt_to_endpoint, set_position, and set_tilt_position - Simplify devices_from_config() in cover.py with data-driven loop over _TIMING_DEFAULTS, extract _get_value() and _resolve_input_mode() - Apply ruff formatting fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ning Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Fixes "Task was destroyed but it is pending" warnings in CI by cancelling any leftover _startup_delay_task when tests finish. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

… registration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…change handler Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add comprehensive tests for previously uncovered areas: - cover_base.py: properties, state restoration, auto_updater, echo filtering, external state changes, delayed_stop, tilt constraints - cover.py: factory function, YAML config parsing, platform setup - cover_switch.py/cover_switch_mode.py: external state change handlers - cover_toggle_mode.py: _send_close with stop switch - config_flow.py: full config/options flow, helpers, validation - __init__.py: integration setup/unload/options update lifecycle Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

clintongormley · 2026-02-18T18:58:15Z

Hi @Sese-Schneider

I'm closing this PR as this really needs to go on top of the PR for UI configuration and calibration. I'll open a bigger PR later.

clintongormley and others added 30 commits February 16, 2026 12:10

docs: add UI config flow design document

92271b8

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

docs: add UI config flow implementation plan

154985a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add config_flow to manifest.json

6db0ac2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Create __init__.py for Cover Time Based integration

22c1b6b

Adds the main integration entry point that handles config entry setup, unload, and options updates. Forwards setup to the cover platform. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: deprecate YAML configuration with repair issue

2600c49

Add deprecation warning log and repair issue when covers are configured via YAML, directing users to recreate via the UI helpers page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: add missing description to user step in translations

c777b00

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add input mode subclasses design doc

8e5e21d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add input mode subclasses implementation plan

f035c15

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: restore async_write_ha_state in set_known_position/set_known_til…

78d1c6f

…t_position Use _async_handle_command(SERVICE_STOP_COVER) instead of bare _send_stop() to ensure self._state is set and async_write_ha_state() is called. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ci: add GitHub Actions workflow for tests and linting

93bc659

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

ci: set asyncio_default_fixture_loop_scope to silence deprecation war…

c9ae097

…ning Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test: cancel pending startup delay tasks in fixture teardown

38cf3da

Fixes "Task was destroyed but it is pending" warnings in CI by cancelling any leftover _startup_delay_task when tests finish. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test: cancel pending startup delay tasks in fixture teardown

a40cd11

Fixes "Task was destroyed but it is pending" warnings in CI by cancelling any leftover _startup_delay_task when tests finish. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

docs: add state monitoring design document

79f5fed

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

docs: add state monitoring implementation plan

ac377f8

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat(state-monitoring): add imports, instance variables, and listener…

e83a8af

… registration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

clintongormley and others added 5 commits February 17, 2026 11:56

feat(state-monitoring): add echo filtering, external flag, and state …

4d3af6d

…change handler Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

style: fix formatting and remove unused imports

91ea6a5

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chore: add .coverage to .gitignore and remove from tracking

cbccbc6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

test: cancel _delay_task in test to prevent lingering task error

3d69e16

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

clintongormley closed this Feb 18, 2026

clintongormley deleted the feat/state-monitoring branch February 21, 2026 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add state monitoring for external cover changes#46

feat: add state monitoring for external cover changes#46
clintongormley wants to merge 35 commits intoSese-Schneider:mainfrom
clintongormley:feat/state-monitoring

clintongormley commented Feb 17, 2026 •

edited

Loading

Uh oh!

clintongormley commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

clintongormley commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

clintongormley commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clintongormley commented Feb 17, 2026 •

edited

Loading