fix: add direction change delay to prevent immediate reversal#55
Open
clintongormley wants to merge 1 commit intoSese-Schneider:mainfrom
Open
fix: add direction change delay to prevent immediate reversal#55clintongormley wants to merge 1 commit intoSese-Schneider:mainfrom
clintongormley wants to merge 1 commit intoSese-Schneider:mainfrom
Conversation
When reversing direction (e.g. opening while closing), the motor needs time to stop before receiving a new direction command. Without this delay, the new direction pulse fires immediately after the stop, which can cause problems with motor controllers. Adds a 1s delay between stop and direction change in async_open_cover, async_close_cover, and set_position. The delay applies to all modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
clintongormley
added a commit
to clintongormley/ha-cover-time-based
that referenced
this pull request
Mar 10, 2026
Merge of Sese-Schneider#55. Adds a 1s pause between stopping and changing direction to let the motor settle. Toggle mode overrides with pulse_time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_direction_change_delay()in the base classasync_open_cover,async_close_cover, andset_positionTest plan
🤖 Generated with Claude Code