Remove validSets state, #getValidSets method

Author: cgewecke

contracts/factories/DelegatedManagerFactory.sol

@@ -81,14 +81,6 @@ contract DelegatedManagerFactory {
     // Mapping which stores manager creation metadata between creation and initialization steps
     mapping(ISetToken=>InitializeParams) public initializeState;
 
-    // Mapping of all Sets that have been created by this factory
-    // NOTE: these may be pending initialization
-    mapping(ISetToken=>bool) public isValidSet;
-
-    // Address array of all Sets that have been created by this factory.
-    // NOTE: these may be pending initialization
-    address[] internal validSets;
-
     /* ============ Constructor ============ */
 
     /**
@@ -255,18 +247,8 @@ contract DelegatedManagerFactory {
         initializeState[_setToken].manager.transferOwnership(initializeState[_setToken].owner);
 
         delete initializeState[_setToken];
-        emit DelegatedManagerInitialized(_setToken, manager);
-    }
-
-    /* ============ External View Functions ============ */
 
-    /**
-     * Returns list of sets that have been successfully initialized by this factory
-     *
-     * @return address[] List of valid sets
-     */
-    function getValidSets() external view returns (address[] memory) {
-        return validSets;
+        emit DelegatedManagerInitialized(_setToken, manager);
     }
 
     /* ============ Internal Functions ============ */
@@ -369,9 +351,6 @@ contract DelegatedManagerFactory {
             manager: IDelegatedManager(_manager),
             isPending: true
         });
-
-        isValidSet[_setToken] = true;
-        validSets.push(address(_setToken));
     }
 
 

test/factories/delegatedManagerFactory.spec.ts

@@ -558,7 +558,7 @@ describe("DelegatedManagerFactory", () => {
         expect(newManager).eq(initializeParams.manager);
       });
 
-      it("should transfer ownership of DelegateManager to the `owner` specified initializeState", async () => {
+      it("should transfer ownership of DelegatedManager to the `owner` specified initializeState", async () => {
         const oldOwner = await manager.owner();
 
         await subject();
@@ -699,39 +699,4 @@ describe("DelegatedManagerFactory", () => {
       });
     });
   });
-
-  describe("#getValidSets", () => {
-    let setTokenAddress: Address;
-
-    beforeEach(async() => {
-      const module = setV2Setup.issuanceModule.address;
-      const extension = mockIssuanceExtension.address;
-      const tx = await create(module, extension);
-
-      setTokenAddress = await protocolUtils.getCreatedSetTokenAddress(tx.hash);
-
-      const initializeParams = await delegatedManagerFactory.initializeState(setTokenAddress);
-      const initializeTargets = [module, extension];
-      const initializeBytecode = await generateBytecode(setTokenAddress, initializeParams.manager);
-
-      await delegatedManagerFactory.initialize(
-        setTokenAddress,
-        ether(.5),
-        await getRandomAddress(),
-        initializeTargets,
-        initializeBytecode
-      );
-    });
-
-    async function subject(): Promise<string[]> {
-      return await delegatedManagerFactory.getValidSets();
-    }
-
-    it("should return valid sets", async() => {
-      const validSets = await subject();
-
-      expect(validSets.length).eq(1);
-      expect(validSets.includes(setTokenAddress)).eq(true);
-    });
-  });
 });