Rename invokeManager to _invokeManager (because internal)

cgewecke · cgewecke · commit 85f4c490eeb8 · 2022-03-03T09:26:57.000-08:00
diff --git a/contracts/lib/BaseGlobalExtension.sol b/contracts/lib/BaseGlobalExtension.sol
@@ -87,14 +87,14 @@ abstract contract BaseGlobalExtension {
      * @param _module           Module to interact with
      * @param _encoded          Encoded byte data
      */
-    function invokeManager(ISetToken _setToken, address _module, bytes memory _encoded) internal {
+    function _invokeManager(ISetToken _setToken, address _module, bytes memory _encoded) internal {
         _manager(_setToken).interactManager(_module, _encoded);
     }
 
     /**
      * Internal function to grab manager of passed SetToken from extensions data structure.
      *
-     * @param _setToken         SetToken who's manager is needed 
+     * @param _setToken         SetToken who's manager is needed
      */
     function _manager(ISetToken _setToken) internal virtual view returns (IDelegatedManager);
 }
diff --git a/contracts/mocks/BaseGlobalExtensionMock.sol b/contracts/mocks/BaseGlobalExtensionMock.sol
@@ -41,7 +41,7 @@ contract BaseGlobalExtensionMock is BaseGlobalExtension {
     }
 
     function testInvokeManager(ISetToken _setToken, address _module, bytes calldata _encoded) external {
-        invokeManager(_setToken, _module, _encoded);
+        _invokeManager(_setToken, _module, _encoded);
     }
 
     function testOnlyOwner(ISetToken _setToken)

Original file line number	Diff line number	Diff line change
`@@ -87,14 +87,14 @@ abstract contract BaseGlobalExtension {`
`87`	`87`	`* @param _module Module to interact with`
`88`	`88`	`* @param _encoded Encoded byte data`
`89`	`89`	`*/`
`90`		`- function invokeManager(ISetToken _setToken, address _module, bytes memory _encoded) internal {`
	`90`	`+ function _invokeManager(ISetToken _setToken, address _module, bytes memory _encoded) internal {`
`91`	`91`	`_manager(_setToken).interactManager(_module, _encoded);`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`/**`
`95`	`95`	`* Internal function to grab manager of passed SetToken from extensions data structure.`
`96`	`96`	`*`
`97`		`- * @param _setToken SetToken who's manager is needed`
	`97`	`+ * @param _setToken SetToken who's manager is needed`
`98`	`98`	`*/`
`99`	`99`	`function _manager(ISetToken _setToken) internal virtual view returns (IDelegatedManager);`
`100`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ contract BaseGlobalExtensionMock is BaseGlobalExtension {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`function testInvokeManager(ISetToken _setToken, address _module, bytes calldata _encoded) external {`
`44`		`- invokeManager(_setToken, _module, _encoded);`
	`44`	`+ _invokeManager(_setToken, _module, _encoded);`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`function testOnlyOwner(ISetToken _setToken)`