Relationships with classes #224
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using classes for my models. Which means that the function
lodash.isPlainObjectreturns false. Even if it should serialize the relationship.I changed this
jsonapi-serializer/lib/serializer-utils.js
Line 19 in 2c3b80f
to
return Array.isArray(obj) || isObjectLike(obj);which yields the correct results for me.To make sure it keeps working I copied existing tests using plain object to use classes instead. They where failing before my fix and now work.