fix(dbus) make dbus path parth of a CompositeDevice at construction#266
Merged
ShadowApex merged 1 commit intoShadowBlip:mainfrom Jan 26, 2025
Merged
fix(dbus) make dbus path parth of a CompositeDevice at construction#266ShadowApex merged 1 commit intoShadowBlip:mainfrom
ShadowApex merged 1 commit intoShadowBlip:mainfrom
Conversation
NeroReflex
force-pushed
the
dbus_fix
branch
2 times, most recently
from
ab80e7f to
d8c8bfa
Compare
ShadowApex
approved these changes
Jan 25, 2025
Contributor
ShadowApex
left a comment
ShadowApex
left a comment
There was a problem hiding this comment.
Minor suggestion, but otherwise looks good! Thanks for this!
DBus path cannot be None as part of the code expects it and it will call .unwrap() on the option potentially crashing the software: construct a CompositeDevice with that value in place and ready for every other subsequent usage.
pastaq
approved these changes
Jan 26, 2025
Contributor
|
🎉 This PR is included in version 0.42.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of the dbus for CompositeDevice: makes it so a dbus is required to have a CompositeDevice and in no situation the service can crash/panic by removing the .unwrap(). It also simplify the code a bit decreasing lines count.
This is also part of the saga "do not spawn tasks without returning the handle and try not to lose tasks references" albeit in this case the reference is still lost, but it is lost in manager.rs and a future code improvement can pick it up.