fix: always call write_set_report_reply to avoid timeout and fail in response to SetReport #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…response to SetReport
ShadowApex
approved these changes
Dec 31, 2025
Contributor
ShadowApex
left a comment
ShadowApex
left a comment
There was a problem hiding this comment.
Great find! Thank you for this!
pastaq
approved these changes
Jan 1, 2026
Contributor
|
🎉 This PR is included in version 0.70.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #459 where games stop reading from controller because IOCTL_HID_SET_FEATURE times out and fails.
(The issue with
Unable to create initialized UdevDeviceis separate and I haven't figured that one out yet.)