fix(CompositeDevice): remove deadlock and perform target device work in parallel #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a rare deadlock where a force feedback event can cause the target device to wait for a
FFUploadresponse from the composite device while the composite device is waiting for a response from the target device about its capabilities. Requests for the capabilities of target devices will now happen asynchronously in its own task to allow the composite device to continue processing other requests.This change also updates some of the target device handling logic to perform certain requests in parallel using a
JoinSetinstead of performing requests serially.Now certain commands, like
SetTargetDeviceswill perform much faster:Serial
Parallel