fix(Input Manager): process newly added devices in a separate task to avoid blocking manager#521
Draft
ShadowApex wants to merge 1 commit intomainfrom
Draft
fix(Input Manager): process newly added devices in a separate task to avoid blocking manager#521ShadowApex wants to merge 1 commit intomainfrom
ShadowApex wants to merge 1 commit intomainfrom
Conversation
ShadowApex
force-pushed
the
shadowapex/async-on-source-added
branch
5 times, most recently
from
e2e1c3a to
525db0e
Compare
… avoid blocking manager This change updates the input manager to process adding new devices primarily inside an async task to allow the input manager to continue to process other requests. Some hardware is slow to respond, so this ensures that slow udev reads do not block other manager commands.
ShadowApex
force-pushed
the
shadowapex/async-on-source-added
branch
from
525db0e to
7bf663f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the input manager to process adding new devices primarily inside an async task to allow the input manager to continue to process other requests. Some hardware is slow to respond, so this ensures that slow udev reads do not block other manager commands.
Fixes #519