Skip to content

Comments

fix(Library): handle bad file open for invalid desktop entries#429

Merged
ShadowApex merged 1 commit intomainfrom
shadowapex/library-desktop-fix
Jan 23, 2025
Merged

fix(Library): handle bad file open for invalid desktop entries#429
ShadowApex merged 1 commit intomainfrom
shadowapex/library-desktop-fix

Conversation

@ShadowApex
Copy link
Collaborator

This change gracefully handles cases where file access reads may fail when reading desktop file entries.

@ShadowApex ShadowApex requested a review from pastaq January 23, 2025 05:29
Copy link
Collaborator

@pastaq pastaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we throw a warning? I don't expect a lot of noise and it could help people discover why a game isn't loading.

@ShadowApex
Copy link
Collaborator Author

Should we throw a warning? I don't expect a lot of noise and it could help people discover why a game isn't loading.

Sure

@ShadowApex ShadowApex force-pushed the shadowapex/library-desktop-fix branch from f200c93 to 9f593c9 Compare January 23, 2025 06:55
@ShadowApex ShadowApex requested a review from pastaq January 23, 2025 06:55
@ShadowApex ShadowApex merged commit ea0661a into main Jan 23, 2025
2 checks passed
@ShadowApex ShadowApex deleted the shadowapex/library-desktop-fix branch January 23, 2025 16:20
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.35.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants