fix(Power Saver): move node to bottom of scene tree to process inputs first #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowApex
force-pushed
the
shadowapex/fix-powersaver-input
branch
from
30094f0 to
af215e0
Compare
pastaq
approved these changes
Jul 6, 2025
|
thank you! |
|
🎉 This PR is included in version 0.40.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the
PowerSavernode, which manages screen dimming and suspend after inactivity, to the bottom of the scene tree in order to process gamepad inputs before anything else.In Godot, the scene tree processes inputs in this order (https://docs.godotengine.org/en/stable/tutorials/inputs/inputevent.html#how-does-it-work):
Note
This should resolve issues with gamepad input, but it's possible that the
PowerSaverwill not see any input events if a user is playing a game using only using a mouse and keyboard. To resolve this, we use theGAMESCOPE_INPUT_COUNTERgamescope property to monitor how long ago mouse/keyboard activity happened.Fixes #471