Fix/remove PHP 8.2 depreciation messages by krytenuk · Pull Request #397 · Shardj/zf1-future

krytenuk · 2024-01-02T15:43:31Z

I was getting deprecation notices after updating a project to PHP 8.2.
Have added type hints and property defaults along with a general code tidy on the worked files.

Fixed doc-block typo and corrected some doc-block property types Added method return types Added int type cast

Added empty array default values

Updated doc-blocks General code tidy

sreichel · 2024-01-21T22:11:54Z

Type hints are breaking changes, not?

develart-projects · 2024-01-23T17:08:08Z

As failing tests are suggesting, these are breaking changes, not really backward compatible. Therefore I'm against this PR to be merged.

krytenuk · 2024-02-04T19:56:18Z

Changed the default delimiters to null. Hopefully fixed phpunit errors.

# Conflicts: # library/Zend/Controller/Action.php # library/Zend/Session/SaveHandler/DbTable.php

library/Zend/Controller/Action.php

boenrobot · 2024-02-05T10:25:30Z

library/Zend/Session/SaveHandler/DbTable.php

     * Retrieve session lifetime
     *
-     * @return int
+     * @return bool|int


Suggested change

* @return bool|int

* @return int|false

for consistency with the property.

library/Zend/Controller/Action.php

Added return to render method Updated method return types

develart-projects · 2024-07-22T12:23:15Z

Well, we still have tons of hints, forcing some type. Like:
public function getViewScript(?string $action = null, ?bool $noController = null): string

Why exactly we are trying to be more typed here pls? Wgat are those deprecation messages about?
By merging this, consequences could be huge in terms of backward compatibility.

IMSoP · 2024-10-08T16:25:02Z

My guess is this is about PHP adding "tentative return types" to built-in classes, and giving (non-error) messages like this:

Deprecated: Return type of Example::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

As the message says, the backward-compatible way of acknowledging but silencing the notice is to add a #[\ReturnTypeWillChange] attribute. If placed on its own line, this looks like a comment to older versions of PHP, so is completely safe. Note that all that does is reduce the logging of the message; the actual problem will probably have to be tackled if and when someone wants a version of this library working on PHP 9.0.

See this Stack Overflow reference question for a deeper explanation.

sreichel · 2025-11-09T21:53:27Z

library/Zend/Controller/Action.php

     * @throws Zend_Controller_Exception if base view directory does not exist
     */
-    public function initView()
+    public function initView(): Zend_View_Interface


Suggested change

public function initView(): Zend_View_Interface

public function initView()

sreichel · 2025-11-09T21:53:57Z

library/Zend/Controller/Action.php

+     * @see Zend_Controller_Response_Abstract::appendBody()
     */
-    public function render($action = null, $name = null, $noController = false)
+    public function render(?string $action = null, ?string $name = null, bool $noController = false): void


Suggested change

public function render(?string $action = null, ?string $name = null, bool $noController = false): void

public function render($action = null, $name = null, $noController = false)

sreichel · 2025-11-09T21:54:17Z

library/Zend/Controller/Action.php

+     * @throws Zend_Controller_Exception
     */
-    public function renderScript($script, $name = null)
+    public function renderScript(string $script, string $name = null): void


Suggested change

public function renderScript(string $script, string $name = null): void

public function renderScript($script, $name = null)

sreichel · 2025-11-09T21:54:40Z

library/Zend/Controller/Action.php

     * @throws Zend_Controller_Exception with bad $action
     */
-    public function getViewScript($action = null, $noController = null)
+    public function getViewScript(?string $action = null, ?bool $noController = null): string


Suggested change

public function getViewScript(?string $action = null, ?bool $noController = null): string

public function getViewScript($action = null, $noController = null)

sreichel · 2025-11-09T21:54:57Z

library/Zend/Controller/Action.php

+     * @return Zend_Controller_Request_Abstract|null
     */
-    public function getRequest()
+    public function getRequest(): ?Zend_Controller_Request_Abstract


Suggested change

public function getRequest(): ?Zend_Controller_Request_Abstract

public function getRequest()

sreichel · 2025-11-09T21:55:13Z

library/Zend/Controller/Action.php

     * @return $this
     */
-    public function setRequest(Zend_Controller_Request_Abstract $request)
+    public function setRequest(Zend_Controller_Request_Abstract $request): Zend_Controller_Action


Suggested change

public function setRequest(Zend_Controller_Request_Abstract $request): Zend_Controller_Action

public function setRequest(Zend_Controller_Request_Abstract $request)

... please remove added type tints. Thats a breaking change and not required to fix deprecation issues ...

garryxigen and others added 6 commits November 1, 2023 14:58

Removed void return

be539f5

Fixed doc-block typo and corrected some doc-block property types Added method return types Added int type cast

Removed array type declaration

e3f6fb7

Added empty array default values

Changed _classMethods default value to null

b17f8fe

Changed _classMethods default value to null

ca99b80

Merge branch 'Shardj:master' into fix/remove-depreciation-messages

eab73ee

Added type hints

bfa935a

Updated doc-blocks General code tidy

develart-projects self-requested a review January 23, 2024 17:08

develart-projects added the requested change some changes are needed before the merge label Jan 23, 2024

develart-projects marked this pull request as draft January 26, 2024 10:25

garryxigen added 2 commits February 4, 2024 19:52

Changed default delimiters to null

0453779

Corrected doc-block typo

8b2092a

Merge branch 'master' into fix/remove-depreciation-messages

207e0cf

# Conflicts: # library/Zend/Controller/Action.php # library/Zend/Session/SaveHandler/DbTable.php

krytenuk marked this pull request as ready for review February 4, 2024 21:33

boenrobot reviewed Feb 5, 2024

View reviewed changes

library/Zend/Controller/Action.php Outdated Show resolved Hide resolved

boenrobot reviewed Feb 5, 2024

View reviewed changes

library/Zend/Controller/Action.php Show resolved Hide resolved

garryxigen and others added 4 commits February 25, 2024 15:42

Reverted @return $this docblock changes

3679438

Added return to render method Updated method return types

Merge branch 'Shardj:master' into fix/remove-depreciation-messages

7dd0bbd

Removed init return type

013d7ba

Removed some void return types

bf703df

IMSoP mentioned this pull request Oct 8, 2024

Fixes deprecated errors on PHP 8.3 #448

Closed

develart-projects marked this pull request as draft October 14, 2024 15:44

Merge branch 'master' into fix/remove-depreciation-messages

5f88a9c

sreichel reviewed Nov 9, 2025

View reviewed changes

IMSoP mentioned this pull request Nov 23, 2025

Any Plan to make compatible with PHP 8.4 ? #446

Open

	public function initView(): Zend_View_Interface
	public function initView()

	public function render(?string $action = null, ?string $name = null, bool $noController = false): void
	public function render($action = null, $name = null, $noController = false)

	public function renderScript(string $script, string $name = null): void
	public function renderScript($script, $name = null)

	public function getViewScript(?string $action = null, ?bool $noController = null): string
	public function getViewScript($action = null, $noController = null)

	public function getRequest(): ?Zend_Controller_Request_Abstract
	public function getRequest()

	public function setRequest(Zend_Controller_Request_Abstract $request): Zend_Controller_Action
	public function setRequest(Zend_Controller_Request_Abstract $request)

Conversation

krytenuk commented Jan 2, 2024

Uh oh!

sreichel commented Jan 21, 2024

Uh oh!

develart-projects commented Jan 23, 2024

Uh oh!

krytenuk commented Feb 4, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

develart-projects commented Jul 22, 2024

Uh oh!

IMSoP commented Oct 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants