Skip to content

Conversation

@bkayfitz
Copy link

Here are all the changes required to get this great library to run in Flutter 2. Most of these changes were determined from the automated migration tool, but probably still warrants a quick review.

@ralflorent
Copy link

ralflorent commented Jul 9, 2021

Nice work, buddy! I wonder why this PR is not accepted and merged yet. Just guessing...

@brian-kayfitz
Copy link

Hey @ralflorent Thanks for the feedback! Not sure why the PR was not accepted. I'm thinking this package is not really maintained anymore. You can use my fork of this package if you want to run it with Non Nullable Dart.

https://github.com/bkayfitz/flutter_tindercard/tree/null_safety

If there is enough demand I could upload that fork to pub.dev. Though I really would prefer to avoid creating more noise on that site...

@5tigerjelly
Copy link

Thank you @bkayfitz for writing this. For others needing null safety checks you can use the repo directly like this. Uploading to pub.dev could confuse people between this repo and yours. Even though this repo isn't maintained.

dependencies:
  flutter_tindercard:
    git: https://github.com/bkayfitz/flutter_tindercard.git

@brian-kayfitz
Copy link

@5tigerjelly Thanks for the feedback. Its been a long time since I made this change (over a year ago) It seems like we should just upload a new version of this package to pub.dev. Which is unfortunate. I would have preferred to not add more clutter that site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants