Packaging with rye, CLI for latin2shaw#72
Open
intarga wants to merge 5 commits intoShavian-info:mainfrom
Open
Conversation
Owner
|
Thank you. This looks really exciting. I will need a little time, maybe a week, to get up to speed on this. I hope that's okay. But on a first review it looks like this will do a lot that I've thought would be good to do, but which are a little beyond my current abilities. |
Author
|
No rush! And please do reach out if you have any questions |
Author
|
@Shavian-info How's it going? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides dependency management and packaging infrastructure using rye, along with a command line interface for latin2shaw, with the goal of making the script easier and more pleasant to use:
rye build && rye publish, which would let users install the script withpip install readlexinstead of having to clone the repo and figure out the dependencies.rye syncto install the dependencies (including the model) automatically, and keep them sandboxed so they don't interfere with other python projects.Let me know if you would like any of this to be done differently, I'm happy to change it. Alternatively if it turns out this is not a wanted feature, I'm also happy to maintain it as a fork.
Some warnings though: