Skip to content

Conversation

@shaerpour
Copy link
Contributor

Add new counter_running_containers_total metric to container_exporter

Closes #36

@Shayan-Ghani
Copy link
Owner

Thanks for your contribution @shaerpour,
For some reason i can't seem to find the new metric you've added on the ci-development workflows, I'll check and keep u updated

@Shayan-Ghani
Copy link
Owner

the problem was with the healthcheck-ci script your code LGTM.

Copy link
Owner

@Shayan-Ghani Shayan-Ghani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch on _metrics.

@Shayan-Ghani Shayan-Ghani merged commit 81e8443 into Shayan-Ghani:master Jun 1, 2025
5 of 6 checks passed
@shaerpour shaerpour deleted the feat/counter_running_containers_total-metric branch June 1, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CXP_Running_Cotainers_Total Metric

2 participants