Skip to content

Fixes for Twitter sharing #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbresjer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes for Twitter sharing #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions android/src/main/kotlin/com/shekarmudaliyar/social_share/SocialSharePlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import io.flutter.plugin.common.MethodChannel.MethodCallHandler
import io.flutter.plugin.common.MethodChannel.Result
import io.flutter.plugin.common.PluginRegistry.Registrar
import java.io.File
import java.net.URLEncoder

class SocialSharePlugin:FlutterPlugin, MethodCallHandler, ActivityAware {
private lateinit var channel: MethodChannel
Expand Down Expand Up @@ -159,9 +160,10 @@ class SocialSharePlugin:FlutterPlugin, MethodCallHandler, ActivityAware {
}
} else if (call.method == "shareTwitter") {
//shares content on twitter
val text: String? = call.argument("captionText")
val url: String? = call.argument("url")
val trailingText: String? = call.argument("trailingText")
val text: String? = URLEncoder.encode(call.argument("captionText"), "utf-8")
val url: String? = URLEncoder.encode(call.argument("url"), "utf-8")
val trailingText: String? = URLEncoder.encode(call.argument("trailingText"), "utf-8")

val urlScheme = "http://www.twitter.com/intent/tweet?text=$text$url$trailingText"
Log.d("log",urlScheme)
val intent = Intent(Intent.ACTION_VIEW)
Expand Down
9 changes: 4 additions & 5 deletions ios/Classes/SocialSharePlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,11 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
result([NSNumber numberWithBool:YES]);
} else if ([@"shareTwitter" isEqualToString:call.method]) {
// NSString *assetImage = call.arguments[@"assetImage"];
NSString *captionText = call.arguments[@"captionText"];
NSString *urlstring = call.arguments[@"url"];
NSString *trailingText = call.arguments[@"trailingText"];
NSString *captionText = [call.arguments[@"captionText"] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSString *urlstring = [call.arguments[@"url"] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSString *trailingText = [call.arguments[@"trailingText"] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];

NSString* urlTextEscaped = [urlstring stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
NSURL *url = [NSURL URLWithString: urlTextEscaped];
NSURL *url = [NSURL URLWithString: urlstring];
NSURL *urlScheme = [NSURL URLWithString:@"twitter://"];
if ([[UIApplication sharedApplication] canOpenURL:urlScheme]) {
//check if twitter app exists
Expand Down
5 changes: 1 addition & 4 deletions lib/social_share.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,7 @@ class SocialShare {
modifiedUrl = Uri.parse(url ?? '').toString();
}
if (hashtags != null && hashtags.isNotEmpty) {
String tags = "";
hashtags.forEach((f) {
tags += ("%23" + f.toString() + " ").toString();
});
final tags = hashtags.map((t) => '#$t ').join(' ');
args = <String, dynamic>{
"captionText": captionText + "\n" + tags.toString(),
"url": modifiedUrl,
Expand Down