Change return type to bool for shareOption#128
Open
goneall wants to merge 2 commits intoShekarMudaliyar:masterfrom
Open
Change return type to bool for shareOption#128goneall wants to merge 2 commits intoShekarMudaliyar:masterfrom
goneall wants to merge 2 commits intoShekarMudaliyar:masterfrom
Conversation
Fixes ShekarMudaliyar#117 The Dart code is expecting a return type of bool and the Android code is returning a type String. I'm assuming "success" should be translated to True. I looked at the iOS code and it is returning a boolean type for the same function. Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
|
what is needed for this to be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
The Dart code is expecting a return type of bool and the Android code is returning a type String. I'm assuming "success" should be translated to True.
I looked at the iOS code and it is returning a boolean type for the same function.