Skip to content

Conversation

@mpollmeier
Copy link
Collaborator

  • before this change, the entire element would be deserialized
  • because the majority of properties are actually unused, this should save us a lot of time
  • best used in combination with cpg2overflowdb, i.e. we don't first initialize the entire graph, but only the element refs
  • change for binary format: instead of writing string property keys we index the properties, using Nil values to fill gaps
  • since we can hard code the property index and type in the specific classes, there's no need to have this in the binary format
  • internally I'm intending to use only the 'readSpecificProperty' rather than reading all properties - that'll come back as a traversal optimization later though.

@mpollmeier mpollmeier requested a review from ml86 July 2, 2019 09:16
@mpollmeier mpollmeier changed the title WIP: when accessing specific property, only deserialize that one when accessing specific property, only deserialize that one Jul 3, 2019
mpollmeier added 11 commits July 7, 2019 00:48
* before this change, the entire element would be deserialized
* because the majority of properties are actually unused, this should
  save us a lot of time
* best used in combination with cpg2overflowdb, i.e. we don't first
  initialize the entire graph, but only the element refs
* change for binary format: instead of writing string property keys we
  index the properties, using `Nil` values to fill gaps
* since we can hard code the property index and type in the specific
  classes, there's no need to have this in the binary format
* internally I'm intending to use only the 'readSpecificProperty'
  rather than reading all properties - that'll come back as a
  traversal optimization later though.
@mpollmeier mpollmeier changed the title when accessing specific property, only deserialize that one WIP - when accessing specific property, only deserialize that one Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants