Skip to content

🐛 fix: add random suffix to meowda script to avoid conflict between multiprocess #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SigureMo merged 1 commit into from
Dec 14, 2025
Merged

🐛 fix: add random suffix to meowda script to avoid conflict between multiprocess #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cli/init.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fn inject_init_script(shell_profile: &str) -> Result<()> {
let init_script = format!(
r#"
# {meowda_init_comment}
MEOWDA_TMP_SCRIPT="/tmp/meowda-init-tmp.sh"
MEOWDA_TMP_SCRIPT="/tmp/meowda-init-tmp-$RANDOM.sh"
Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using $RANDOM for temporary file naming has several issues:

  1. Shell compatibility: $RANDOM is specific to Bash and Zsh, but won't work in POSIX sh or other shells like dash, which may cause the initialization to fail on some systems.

  2. Security concern: $RANDOM generates predictable values (0-32767), making it vulnerable to race conditions and potential security issues in /tmp directories.

  3. Better alternative: Use the mktemp command instead, which is POSIX-compliant, generates cryptographically secure unique filenames, and automatically handles race conditions.

Consider changing this line to use mktemp:
MEOWDA_TMP_SCRIPT="$(mktemp /tmp/meowda-init-tmp.XXXXXX.sh)"

This ensures cross-shell compatibility and eliminates the race condition security concern.

Suggested change
MEOWDA_TMP_SCRIPT="/tmp/meowda-init-tmp-$RANDOM.sh"
MEOWDA_TMP_SCRIPT="$(mktemp /tmp/meowda-init-tmp.XXXXXX.sh)"

Copilot uses AI. Check for mistakes.
meowda generate-init-script > "$MEOWDA_TMP_SCRIPT"
source "$MEOWDA_TMP_SCRIPT"
rm -f "$MEOWDA_TMP_SCRIPT"
Expand Down