Merged
Conversation
…ependencies script)
…show artifact listings
…--debug and list build logs
…y*.node to build/Release
…inding pty*.node (no auto-copy hack)
- Remove patch-package from postinstall in dev - Apply patch only in CI build job after placing prebuilds - Clean prebuilds directory before placing custom binaries - Force rebuild in prebuild jobs with --ignore-scripts
- Switch from ubuntu:20.04 (glibc 2.31) to ubuntu:18.04 (glibc 2.27) - Improves compatibility with older distributions
- Revert from ubuntu:18.04 to ubuntu:20.04 for glibc compatibility with GitHub Actions - Simplify action references to @v5 for testing - Ubuntu 20.04 has glibc 2.31 which works with checkout@v5 (Node.js 24)
- Use gcc-10 from official Ubuntu 20.04 repos instead of gcc-11 from PPA - Remove PPA dependency for simpler and more reliable setup - gcc-10 supports C++20 standard required for node-pty compilation - Add DEBIAN_FRONTEND=noninteractive for non-interactive package install
- Move npx patch-package to Setup Node step after npm install - Eliminates need for separate Apply patch step - Ensures nvm environment is active when running npx - More logical workflow sequence and easier to maintain
- Simplify structure: copy linux-unpacked directly to AppDir/ - Remove unnecessary ICON and DESKTOP exports (auto-detected) - Remove DEPLOY_OPENGL/VULKAN exports (Electron includes all needed) - Add SKIP_DEPS=1 to prevent automatic dependency bloat - Implement VERSION with github.run_number for auto-incrementing - Update desktop file to point to correct executable path
- Point quick-sharun to analyze ./AppDir/am-gui binary - Remove invalid SKIP_DEPS variable (not supported) - Enable proper AppRun download and dependency detection - Should create functional AppImage with minimal necessary deps
- Separate dependency deployment and AppImage creation steps - Deploy dependencies with quick-sharun ./AppDir/am-gui - Create AppImage with quick-sharun --make-appimage - Fix typo in executable name (am-guie → am-gui) - Allow additional modifications between deployment and packaging
- Fix AM-GUI.png path (remove incorrect AM-GUI/ prefix) - Fix AM-GUI.desktop path (remove incorrect AM-GUI/ prefix) - Copy AM-GUI.png as .DirIcon for AppImage icon - Copy AM-GUI.desktop to AppDir root for desktop entry - Files are located at project root, not in subdirectory
- Move linux-unpacked content to ./AppDir/bin/ instead of ./AppDir/ - Update desktop entry Exec path to bin/am-gui - Update make-appimage.sh to point to ./AppDir/bin/am-gui - Maintain standard AppImage structure with binaries in bin/ - Keep .DirIcon and .desktop at AppDir root level
- Remove separate dependency deployment step - Use quick-sharun --make-appimage directly - Copy linux-unpacked directly to AppDir/ root - Desktop entry points to am-gui (no bin/ prefix) - Test if AppRun generation works with minimal approach
- Uncommented quick-sharun ./AppDir/bin/am-gui call - This ensures AppRun is created during dependency deployment phase - Fixes previous AppImage creation failures due to missing AppRun - Dependencies will be properly scanned and AppRun generated automatically
- Move linux-unpacked contents to AppDir/bin/ instead of AppDir/ - Update desktop entry Exec path to bin/am-gui - This structure aligns better with quick-sharun expectations - Should improve AppRun generation and AppImage functionality
- Ajout de curl à l'étape d'installation des outils - Correction du chemin Exec dans AM-GUI.desktop (am-gui %U) - Correction du chemin de déploiement dans get-dependencies.sh (linux-unpacked -> AppDir) - quick-sharun appelé sur AppDir/bin dans make-appimage.sh - Nettoyage des commentaires inutiles
…temporaire quick-sharun dans make-appimage.sh
- Place linux-unpacked dans AppDir/bin - quick-sharun appelé sur tous les binaires du dossier bin - Nettoyage copie AppRun inutile
Shikakiben
added a commit
that referenced
this pull request
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.