improve generate func, fix support for other file imgs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the image generation functionality by replacing PNG-specific processing with a more flexible image handling approach using Sharp library to support additional image formats.
- Replaced PNG.js with Sharp library for broader image format support
- Updated React Image component to native img element for better compatibility
- Added comprehensive error handling in the upload API route
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Added Sharp library dependency for enhanced image processing |
| app/generate/page.tsx | Changed from Next.js Image component to native img element |
| app/api/upload/route.ts | Replaced PNG.js with Sharp for multi-format support and improved error handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+20
to
+27
| const image = sharp(buffer).ensureAlpha(); // ensures RGBA format | ||
| const { width, height } = await image.metadata(); | ||
|
|
||
| if (!width || !height) { | ||
| throw new Error("Unable to read image metadata."); | ||
| } | ||
|
|
||
| const raw = await image.raw().toBuffer(); |
There was a problem hiding this comment.
The Sharp instance is created twice - once for metadata extraction and once for raw buffer processing. Consider reusing the same instance or chaining operations to avoid redundant processing.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix support for other file imgs